Closed Bug 1449039 Opened 6 years ago Closed 6 years ago

Remove some unused stuff from nsCSSProps & nsCSSPropList

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:

Component:

Type:

enhancement

Priority:

Not set

Severity:

normal

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla61

Tracking Flags:

Tracking

Status

firefox61

---

fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(13 files)

Bug 1449039 part 1 - Remove Property{Count,Index}InStruct. 6 years ago Xidorn Quan [:xidorn] UTC+11 59 bytes, text/x-review-board-request	emilio : review+	Details
Bug 1449039 part 2 - Remove LogicalGroup. 6 years ago Xidorn Quan [:xidorn] UTC+11 59 bytes, text/x-review-board-request	emilio : review+	Details
Bug 1449039 part 3 - Remove kStyleStructOffsetTable. 6 years ago Xidorn Quan [:xidorn] UTC+11 59 bytes, text/x-review-board-request	emilio : review+	Details
Bug 1449039 part 4 - Remove ValueRestrictions and its related flags. 6 years ago Xidorn Quan [:xidorn] UTC+11 59 bytes, text/x-review-board-request	emilio : review+	Details
Bug 1449039 part 5 - Remove CSS_PROPERTY_{ABS,FIX}POS_CB constants. 6 years ago Xidorn Quan [:xidorn] UTC+11 59 bytes, text/x-review-board-request	emilio : review+	Details
Bug 1449039 part 6 - Remove CSS_PROPERTY_IGNORED_WHEN_COLORS_DISABLED. 6 years ago Xidorn Quan [:xidorn] UTC+11 59 bytes, text/x-review-board-request	emilio : review+	Details
Bug 1449039 part 7 - Remove CSS_PROPERTY_LOGICAL* flags. 6 years ago Xidorn Quan [:xidorn] UTC+11 59 bytes, text/x-review-board-request	emilio : review+	Details
Bug 1449039 part 8 - Remove bunch of unused CSS_PROPERTY_* flags. 6 years ago Xidorn Quan [:xidorn] UTC+11 59 bytes, text/x-review-board-request	emilio : review+	Details
Bug 1449039 part 9 - Remove ShorthandsContainingTable. 6 years ago Xidorn Quan [:xidorn] UTC+11 59 bytes, text/x-review-board-request	emilio : review+	Details
Bug 1449039 part 10 - Remove PredefinedCounterStyleTable. 6 years ago Xidorn Quan [:xidorn] UTC+11 59 bytes, text/x-review-board-request	emilio : review+	Details
Bug 1449039 part 11 - Remove some unused functions in nsCSSProps. 6 years ago Xidorn Quan [:xidorn] UTC+11 59 bytes, text/x-review-board-request	emilio : review+	Details
Bug 1449039 part 12 - Keep only necessary params for CSS_PROP definitions. 6 years ago Xidorn Quan [:xidorn] UTC+11 59 bytes, text/x-review-board-request	emilio : review+	Details
Bug 1449039 part 13 - Remove stylestructoffset arg from CSS_PROPs. 6 years ago Xidorn Quan [:xidorn] UTC+11 59 bytes, text/x-review-board-request	emilio : review+	Details

Xidorn Quan [:xidorn] UTC+11

Assignee

Description

•

6 years ago

      No description provided.

Xidorn Quan [:xidorn] UTC+11

Assignee

Updated

•

6 years ago

Summary: Remove some unused stuff from nsCSSProps → Remove some unused stuff from nsCSSProps & nsCSSPropList

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/231420/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231420/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/231422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231422/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/231424/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231424/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/231426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231426/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/231428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231428/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/231430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231430/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/231432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231432/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/231434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231434/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/231436/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231436/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/231438/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231438/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/231440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231440/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/231442/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231442/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/231444/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231444/

Comment hidden (mozreview-request)

Comment on attachment 8962603 [details]
Bug 1449039 part 9 - Remove ShorthandsContainingTable.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231436/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8962604 [details]
Bug 1449039 part 10 - Remove PredefinedCounterStyleTable.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231438/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8962605 [details]
Bug 1449039 part 11 - Remove some unused functions in nsCSSProps.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231440/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8962606 [details]
Bug 1449039 part 12 - Keep only necessary params for CSS_PROP definitions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231442/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8962607 [details]
Bug 1449039 part 13 - Remove stylestructoffset arg from CSS_PROPs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231444/diff/1-2/

Emilio Cobos Álvarez (:emilio)

Comment 19

•

6 years ago

mozreview-review

Comment on attachment 8962595 [details]
Bug 1449039 part 1 - Remove Property{Count,Index}InStruct.

https://reviewboard.mozilla.org/r/231420/#review236930

Attachment #8962595 - Flags: review?(emilio) → review+

Emilio Cobos Álvarez (:emilio)

Comment 20

•

6 years ago

mozreview-review

Comment on attachment 8962596 [details]
Bug 1449039 part 2 - Remove LogicalGroup.

https://reviewboard.mozilla.org/r/231422/#review236932

Attachment #8962596 - Flags: review?(emilio) → review+

Emilio Cobos Álvarez (:emilio)

Comment 21

•

6 years ago

mozreview-review

Comment on attachment 8962597 [details]
Bug 1449039 part 3 - Remove kStyleStructOffsetTable.

https://reviewboard.mozilla.org/r/231424/#review236934

::: layout/style/nsCSSProps.cpp
(Diff revision 1)
>  
> -const ptrdiff_t
> -nsCSSProps::kStyleStructOffsetTable[eCSSProperty_COUNT_no_shorthands] = {
> -#define CSS_PROP(name_, id_, method_, flags_, pref_, parsevariant_, kwtable_, \
> -                 stylestruct_, stylestructoffset_, animtype_)                 \
> -  stylestructoffset_,

So we can remove also `stylestructoffset_`, right?

Attachment #8962597 - Flags: review?(emilio) → review+

Emilio Cobos Álvarez (:emilio)

Comment 22

•

6 years ago

mozreview-review

Comment on attachment 8962598 [details]
Bug 1449039 part 4 - Remove ValueRestrictions and its related flags.

https://reviewboard.mozilla.org/r/231426/#review236936

Attachment #8962598 - Flags: review?(emilio) → review+

Emilio Cobos Álvarez (:emilio)

Comment 23

•

6 years ago

mozreview-review

Comment on attachment 8962599 [details]
Bug 1449039 part 5 - Remove CSS_PROPERTY_{ABS,FIX}POS_CB constants.

https://reviewboard.mozilla.org/r/231428/#review236938

Attachment #8962599 - Flags: review?(emilio) → review+

Emilio Cobos Álvarez (:emilio)

Comment 24

•

6 years ago

mozreview-review

Comment on attachment 8962600 [details]
Bug 1449039 part 6 - Remove CSS_PROPERTY_IGNORED_WHEN_COLORS_DISABLED.

https://reviewboard.mozilla.org/r/231430/#review236942

Attachment #8962600 - Flags: review?(emilio) → review+

Emilio Cobos Álvarez (:emilio)

Comment 25

•

6 years ago

mozreview-review

Comment on attachment 8962601 [details]
Bug 1449039 part 7 - Remove CSS_PROPERTY_LOGICAL* flags.

https://reviewboard.mozilla.org/r/231432/#review236944

Attachment #8962601 - Flags: review?(emilio) → review+

Emilio Cobos Álvarez (:emilio)

Comment 26

•

6 years ago

mozreview-review

Comment on attachment 8962602 [details]
Bug 1449039 part 8 - Remove bunch of unused CSS_PROPERTY_* flags.

https://reviewboard.mozilla.org/r/231434/#review236946

Attachment #8962602 - Flags: review?(emilio) → review+

Emilio Cobos Álvarez (:emilio)

Comment 27

•

6 years ago

mozreview-review

Comment on attachment 8962603 [details]
Bug 1449039 part 9 - Remove ShorthandsContainingTable.

https://reviewboard.mozilla.org/r/231436/#review236948

Attachment #8962603 - Flags: review?(emilio) → review+

Emilio Cobos Álvarez (:emilio)

Comment 28

•

6 years ago

mozreview-review

Comment on attachment 8962604 [details]
Bug 1449039 part 10 - Remove PredefinedCounterStyleTable.

https://reviewboard.mozilla.org/r/231438/#review236950

Attachment #8962604 - Flags: review?(emilio) → review+

Emilio Cobos Álvarez (:emilio)

Comment 29

•

6 years ago

mozreview-review

Comment on attachment 8962605 [details]
Bug 1449039 part 11 - Remove some unused functions in nsCSSProps.

https://reviewboard.mozilla.org/r/231440/#review236952

Attachment #8962605 - Flags: review?(emilio) → review+

Emilio Cobos Álvarez (:emilio)

Comment 30

•

6 years ago

mozreview-review

Comment on attachment 8962606 [details]
Bug 1449039 part 12 - Keep only necessary params for CSS_PROP definitions.

https://reviewboard.mozilla.org/r/231442/#review236954

Nice :)

Attachment #8962606 - Flags: review?(emilio) → review+

Emilio Cobos Álvarez (:emilio)

Comment 31

•

6 years ago

mozreview-review

Comment on attachment 8962607 [details]
Bug 1449039 part 13 - Remove stylestructoffset arg from CSS_PROPs.

https://reviewboard.mozilla.org/r/231444/#review236956

Attachment #8962607 - Flags: review?(emilio) → review+

Xidorn Quan [:xidorn] UTC+11

Assignee

Comment 32

•

6 years ago

mozreview-review-reply

Comment on attachment 8962597 [details]
Bug 1449039 part 3 - Remove kStyleStructOffsetTable.

https://reviewboard.mozilla.org/r/231424/#review236934

> So we can remove also `stylestructoffset_`, right?

Yes, we do that in the last patch. I should have merged this to the last one, I guess.

Comment 33

•

6 years ago

Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19c6c6d23851
part 1 - Remove Property{Count,Index}InStruct. r=emilio
https://hg.mozilla.org/integration/autoland/rev/dbad81843014
part 2 - Remove LogicalGroup. r=emilio
https://hg.mozilla.org/integration/autoland/rev/1012971212db
part 3 - Remove kStyleStructOffsetTable. r=emilio
https://hg.mozilla.org/integration/autoland/rev/998cddc78fdd
part 4 - Remove ValueRestrictions and its related flags. r=emilio
https://hg.mozilla.org/integration/autoland/rev/0cd1605e61ec
part 5 - Remove CSS_PROPERTY_{ABS,FIX}POS_CB constants. r=emilio
https://hg.mozilla.org/integration/autoland/rev/e9243024ac49
part 6 - Remove CSS_PROPERTY_IGNORED_WHEN_COLORS_DISABLED. r=emilio
https://hg.mozilla.org/integration/autoland/rev/691c5981dea0
part 7 - Remove CSS_PROPERTY_LOGICAL* flags. r=emilio
https://hg.mozilla.org/integration/autoland/rev/9bcd71ecac07
part 8 - Remove bunch of unused CSS_PROPERTY_* flags. r=emilio
https://hg.mozilla.org/integration/autoland/rev/a3bfd093194f
part 9 - Remove ShorthandsContainingTable. r=emilio
https://hg.mozilla.org/integration/autoland/rev/fc1bbcd64803
part 10 - Remove PredefinedCounterStyleTable. r=emilio
https://hg.mozilla.org/integration/autoland/rev/d672ffc5991d
part 11 - Remove some unused functions in nsCSSProps. r=emilio
https://hg.mozilla.org/integration/autoland/rev/c6e9dfb1a652
part 12 - Keep only necessary params for CSS_PROP definitions. r=emilio
https://hg.mozilla.org/integration/autoland/rev/31ba82db8a7d
part 13 - Remove stylestructoffset arg from CSS_PROPs. r=emilio

Eliza Balazs [:ebalazs_]

Comment 34

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/19c6c6d23851
https://hg.mozilla.org/mozilla-central/rev/dbad81843014
https://hg.mozilla.org/mozilla-central/rev/1012971212db
https://hg.mozilla.org/mozilla-central/rev/998cddc78fdd
https://hg.mozilla.org/mozilla-central/rev/0cd1605e61ec
https://hg.mozilla.org/mozilla-central/rev/e9243024ac49
https://hg.mozilla.org/mozilla-central/rev/691c5981dea0
https://hg.mozilla.org/mozilla-central/rev/9bcd71ecac07
https://hg.mozilla.org/mozilla-central/rev/a3bfd093194f
https://hg.mozilla.org/mozilla-central/rev/fc1bbcd64803
https://hg.mozilla.org/mozilla-central/rev/d672ffc5991d
https://hg.mozilla.org/mozilla-central/rev/c6e9dfb1a652
https://hg.mozilla.org/mozilla-central/rev/31ba82db8a7d

Status: NEW → RESOLVED

Closed: 6 years ago

status-firefox61: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla61

You need to log in before you can comment on or make changes to this bug.