1449072 - Intermittent toolkit/mozapps/extensions/test/xpcshell/test_install.js | xpcshell return code: 0

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Treeherder Bug Filer]

Filed by: dluca [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=170445905&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/BgAFdtTNTOalrBFusgxl8w/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1449072: Stop modifying mtime after install.

It makes no sense for bootstrapped installs (and little-to-no sense for
bootstrapped installs), and causes intermittent test failures when it causes
the add-on manager to detect the add-on as changed during startup and throw
away metadata like the sourceURI.

Review commit: https://reviewboard.mozilla.org/r/231484/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231484/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8962622 [details]
Bug 1449072: Stop modifying mtime after install.

https://reviewboard.mozilla.org/r/231484/#review237320

::: commit-message-42994:3
(Diff revision 1)
> +It makes no sense for bootstrapped installs (and little-to-no sense for
> +bootstrapped installs), and causes intermittent test failures when it causes

I don't understand this

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca46aca41fec3bc19bb38f18829c187881ecc229
Bug 1449072: Stop modifying mtime after install. r=aswan

Comment 4

[Intermittent Failures Robot]

39 failures in 168 pushes (0.232 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-inbound: 31
* autoland: 4
* try: 2
* mozilla-central: 2

Platform breakdown:
* windows10-64: 12
* windows7-32: 8
* linux32: 7
* linux64: 6
* osx-10-10: 5
* linux64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1449072&startday=2018-03-27&endday=2018-03-27&tree=trunk

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out changeset for xpcshell failures on xpcshell/test_install.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=00b595c3f22c11a9203bdc9d9d5be9d6dfefe592&fromchange=ca46aca41fec3bc19bb38f18829c187881ecc229&tochange=1c8dd93fbeb071dcc9f54eae22b19da1fc0f4f90&selectedJob=170709557

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=170709557&repo=mozilla-inbound&lineNumber=10103

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/1c8dd93fbeb071dcc9f54eae22b19da1fc0f4f90

Comment 6

[Cosmin Sabou [:CosminS]]

Please also take a look at these failures: https://treeherder.mozilla.org/logviewer.html#?job_id=170743216&repo=mozilla-inbound&lineNumber=10053

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=1c8dd93fbeb071dcc9f54eae22b19da1fc0f4f90&filter-searchStr=741842a2094fa112327a217168661e4756206f35&selectedJob=170743216

Comment 7

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f812d3737abf19e9f95e250974c014fdbc72468e
Bug 1449072: Stop modifying mtime after install. r=aswan

Comment 8

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb48848a375b4374a279ef87794cbc54eadc2f67
Bug 1449072: Follow-up: Skip sourceURI check on Windows for frequent timing issues. r=bustage

Comment 9

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0541c4074a08699d58913bd5d7f797c0af8e3e30
Bug 1449072: Follow-up: Really skip sourceURI check on Windows for frequent timing issues. r=bustage

Comment 10

[Intermittent Failures Robot]

33 failures in 161 pushes (0.205 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-inbound: 20
* autoland: 8
* mozilla-central: 3
* try: 2

Platform breakdown:
* linux64: 9
* windows10-64: 8
* windows7-32: 6
* osx-10-10: 5
* linux32: 4
* linux64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1449072&startday=2018-03-28&endday=2018-03-28&tree=trunk

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f812d3737abf
https://hg.mozilla.org/mozilla-central/rev/eb48848a375b
https://hg.mozilla.org/mozilla-central/rev/0541c4074a08

Comment 12

[Intermittent Failures Robot]

71 failures in 718 pushes (0.099 failures/push) were associated with this bug in the last 7 days. 

This is the #16 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-inbound: 49
* autoland: 13
* mozilla-central: 5
* try: 4

Platform breakdown:
* windows10-64: 18
* linux64: 15
* windows7-32: 14
* osx-10-10: 11
* linux32: 11
* linux64-qr: 1
* linux64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1449072&startday=2018-03-26&endday=2018-04-01&tree=trunk

Comment 13

[Victor Carciu]

Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.