Update various parts of gdb JS::Value integration for the removal of the jsval/jsval_layout types, instead generally referring to Value.h directly

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla61
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

a year ago
No description provided.
Assignee

Comment 1

a year ago
Posted patch Patch (obsolete) — Splinter Review
I can't figure out how to run the gdb tests.  I think the Python script might be out of date to when SpiderMonkey didn't use the Mozilla build system.  Help!
Attachment #8962611 - Flags: review?(sphink)
Assignee

Comment 2

a year ago
With a little help on IRC, I got tests running, and there only seems to have been one last issue to fix.  (There were some pre-existing failures I had to ignore -- clang biting again in one case? -- but separate bug.)
Attachment #8962827 - Flags: review?(sphink)
Assignee

Updated

a year ago
Attachment #8962611 - Attachment is obsolete: true
Attachment #8962611 - Flags: review?(sphink)
Comment on attachment 8962827 [details] [diff] [review]
Updated wrt gdb test results

Review of attachment 8962827 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, this is great! I should probably steal some of this code for mrgiggles's Value parsing; mine is pretty clunky.
Attachment #8962827 - Flags: review?(sphink)
Attachment #8962827 - Flags: review+
Priority: -- → P3

Comment 4

a year ago
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a145bccd887
Update various parts of gdb JS::Value integration for the removal of the jsval/jsval_layout types, instead generally referring to Value.h directly.  r=sfink (5x, lol Bugzilla)

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9a145bccd887
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.