1449099 - Update various parts of gdb JS::Value integration for the removal of the jsval/jsval_layout types, instead generally referring to Value.h directly

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

I can't figure out how to run the gdb tests.  I think the Python script might be out of date to when SpiderMonkey didn't use the Mozilla build system.  Help!

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Updated wrt gdb test results

With a little help on IRC, I got tests running, and there only seems to have been one last issue to fix.  (There were some pre-existing failures I had to ignore -- clang biting again in one case? -- but separate bug.)

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8962827 [details] [diff] [review]
Updated wrt gdb test results

Review of attachment 8962827 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, this is great! I should probably steal some of this code for mrgiggles's Value parsing; mine is pretty clunky.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a145bccd887
Update various parts of gdb JS::Value integration for the removal of the jsval/jsval_layout types, instead generally referring to Value.h directly.  r=sfink (5x, lol Bugzilla)

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9a145bccd887