1449100 - Move network details panel toggle button next to the sidebar tabs

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Do we have any mockup/requirement for this task?

Here is PRD for UX/Photon Polish, perhaps it should be updated?
https://docs.google.com/document/d/1CsxazGLKlZagc1rCt-4j_gqh5WEQLCxN6VUjd5AUTiM/edit#

Honza

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1449100 - Move network details panel toggle buton next to the sidebar tabs.

Review commit: https://reviewboard.mozilla.org/r/234448/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234448/

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a76e3a5a673952825fd5277e4a693366dde4b6ca

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8965608 [details]
Bug 1449100 - Move network details panel toggle buton next to the sidebar tabs.

https://reviewboard.mozilla.org/r/234448/#review240550

Looks great to me, just one question related to localization.

Thanks for working on this!
Honza

::: devtools/client/netmonitor/src/components/TabboxPanel.js:25
(Diff revision 1)
>  const StackTracePanel = createFactory(require("./StackTracePanel"));
>  const TimingsPanel = createFactory(require("./TimingsPanel"));
>  
> +const COLLAPSE_DETAILS_PANE = L10N.getStr("collapseDetailsPane");
>  const COOKIES_TITLE = L10N.getStr("netmonitor.tab.cookies");
> +const EXPAND_DETAILS_PANE = L10N.getStr("expandDetailsPane");

Do we still need this string? The button isn't used to open the Sidebar anymore.

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8965608 [details]
Bug 1449100 - Move network details panel toggle buton next to the sidebar tabs.

https://reviewboard.mozilla.org/r/234448/#review240550

> Do we still need this string? The button isn't used to open the Sidebar anymore.

This is true. We can probably remove it, but I kept it there mainly because SidebarToggle required an expandPaneTitle.

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8965608 [details]
Bug 1449100 - Move network details panel toggle buton next to the sidebar tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/234448/diff/1-2/

Comment 7

[Tim Nguyen :ntim]

Hmm, how would you toggle the sidebar back on ?

Comment 8

[Gabriel Luong [:gl] (ΦωΦ)]

You just select a row in the network requests.

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8965608 [details]
Bug 1449100 - Move network details panel toggle buton next to the sidebar tabs.

https://reviewboard.mozilla.org/r/234448/#review241262

Looks good to me now.

R+ assuming try is green

Thanks for working on this Gabriel!

Honza

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4dcb47b8542
Move network details panel toggle buton next to the sidebar tabs. r=Honza

Comment 11

[Noemi Erli[:noemi_erli]]

Backed out changeset b4dcb47b8542 (bug 1449100) for dt failures in devtools/client/netmonitor/test/browser_net_pane-network-details.js on a CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b4dcb47b854282d4e439f678c79fc2527a215c0d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-classifiedState=unclassified&selectedJob=173191318

Failure log:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b4dcb47b854282d4e439f678c79fc2527a215c0d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-classifiedState=unclassified&selectedJob=173191318

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/55a595f1101e1473c2a63dd04d710f4555f1c490

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e9190687c32
Move network details panel toggle buton next to the sidebar tabs. r=Honza

Comment 13

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/1e9190687c32