Closed Bug 1449100 Opened 2 years ago Closed 2 years ago

Move network details panel toggle button next to the sidebar tabs

Categories

(DevTools :: Netmonitor, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Do we have any mockup/requirement for this task?

Here is PRD for UX/Photon Polish, perhaps it should be updated?
https://docs.google.com/document/d/1CsxazGLKlZagc1rCt-4j_gqh5WEQLCxN6VUjd5AUTiM/edit#

Honza
Depends on: 1449024
Comment on attachment 8965608 [details]
Bug 1449100 - Move network details panel toggle buton next to the sidebar tabs.

https://reviewboard.mozilla.org/r/234448/#review240550

Looks great to me, just one question related to localization.

Thanks for working on this!
Honza

::: devtools/client/netmonitor/src/components/TabboxPanel.js:25
(Diff revision 1)
>  const StackTracePanel = createFactory(require("./StackTracePanel"));
>  const TimingsPanel = createFactory(require("./TimingsPanel"));
>  
> +const COLLAPSE_DETAILS_PANE = L10N.getStr("collapseDetailsPane");
>  const COOKIES_TITLE = L10N.getStr("netmonitor.tab.cookies");
> +const EXPAND_DETAILS_PANE = L10N.getStr("expandDetailsPane");

Do we still need this string? The button isn't used to open the Sidebar anymore.
Attachment #8965608 - Flags: review?(odvarko)
Comment on attachment 8965608 [details]
Bug 1449100 - Move network details panel toggle buton next to the sidebar tabs.

https://reviewboard.mozilla.org/r/234448/#review240550

> Do we still need this string? The button isn't used to open the Sidebar anymore.

This is true. We can probably remove it, but I kept it there mainly because SidebarToggle required an expandPaneTitle.
Hmm, how would you toggle the sidebar back on ?
You just select a row in the network requests.
Comment on attachment 8965608 [details]
Bug 1449100 - Move network details panel toggle buton next to the sidebar tabs.

https://reviewboard.mozilla.org/r/234448/#review241262

Looks good to me now.

R+ assuming try is green

Thanks for working on this Gabriel!

Honza
Attachment #8965608 - Flags: review?(odvarko) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4dcb47b8542
Move network details panel toggle buton next to the sidebar tabs. r=Honza
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e9190687c32
Move network details panel toggle buton next to the sidebar tabs. r=Honza
https://hg.mozilla.org/mozilla-central/rev/1e9190687c32
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Flags: needinfo?(gl)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.