Closed Bug 1449101 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 10190 - Revert "Don't adjust the NavigationTimings on redirects"

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 10190 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10190
Details from upstream follow.

Ben Wells <benwells@chromium.org> wrote:
>  Revert "Don't adjust the NavigationTimings on redirects"
>  
>  This reverts commit aeecb4f32ece14a8a294e4f9b80a5bb2278091c9.
>  
>  Reason for revert: Causing lots of failures on webkit bots, e.g.:
>  https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/42143
>  
>  Original change's description:
>  > Don't adjust the NavigationTimings on redirects
>  > 
>  > We adjust the timings in WebDocumentLoaderImpl::UpdateNavigation(),
>  > shouldn't update in each AddRedirect() (which is called in a batch
>  > way after all the redirects are handled in the browser process with PlzNavigate,
>  > adjusting timings there with current timestamp is totally wrong)
>  > 
>  > R=​ksakamoto,arthursonzogni
>  > 
>  > Bug: 813889
>  > Change-Id: I3a57d3fdf1833c300feb5ee61737b64cece0946b
>  > Reviewed-on: https://chromium-review.googlesource.com/974673
>  > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
>  > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#546001}
>  
>  TBR=kinuko@chromium.org,ksakamoto@chromium.org,arthursonzogni@chromium.org
>  
>  Change-Id: I467ed888084ea0eda06faa903d1797fabffc47da
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 813889
>  Reviewed-on: https://chromium-review.googlesource.com/981912
>  Reviewed-by: Ben Wells <benwells@chromium.org>
>  Commit-Queue: Ben Wells <benwells@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#546025}
>
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3325454495c2
[wpt PR 10190] - Revert "Don't adjust the NavigationTimings on redirects", a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.