Closed Bug 1449118 Opened 4 years ago Closed 4 years ago

Perma-orange TV tier2 layout/reftests/xul/treetwisty-svg-context-paint-1.xul == layout/reftests/xul/treetwisty-svg-context-paint-1-ref.xul | image comparison, max difference: 128, number of differing pixels: 110

Categories

(Core :: SVG, defect, P5)

defect

Tracking

()

VERIFIED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: ntim)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=170478626&repo=autoland

https://queue.taskcluster.net/v1/task/edBPnSQQSAKXiYSl8ypizA/runs/0/artifacts/public/logs/live_backing.log

[task 2018-03-27T07:35:59.834Z] 07:35:59     INFO - REFTEST TEST-START | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/xul/treetwisty-svg-context-paint-1.xul == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/xul/treetwisty-svg-context-paint-1-ref.xul
[task 2018-03-27T07:35:59.842Z] 07:35:59     INFO - REFTEST INFO | SET PREFERENCE pref(svg.context-properties.content.enabled,true)
[task 2018-03-27T07:35:59.844Z] 07:35:59     INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/xul/treetwisty-svg-context-paint-1.xul | 0 / 1 (0%)
[task 2018-03-27T07:36:00.142Z] 07:36:00     INFO - REFTEST INFO | drawWindow flags = DRAWWINDOW_DRAW_CARET | DRAWWINDOW_DRAW_VIEW | DRAWWINDOW_USE_WIDGET_LAYERS; window size = 800,1000; test browser size = 800,1000
[task 2018-03-27T07:36:00.222Z] 07:36:00     INFO - REFTEST INFO | RESTORE PREFERENCE pref(svg.context-properties.content.enabled,false)
[task 2018-03-27T07:36:00.222Z] 07:36:00     INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/xul/treetwisty-svg-context-paint-1-ref.xul | 0 / 1 (0%)
[task 2018-03-27T07:36:00.481Z] 07:36:00     INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/xul/treetwisty-svg-context-paint-1.xul == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/xul/treetwisty-svg-context-paint-1-ref.xul | image comparison, max difference: 128, number of differing pixels: 110
Summary: Intermittent layout/reftests/xul/treetwisty-svg-context-paint-1.xul == layout/reftests/xul/treetwisty-svg-context-paint-1-ref.xul | image comparison, max difference: 128, number of differing pixels: 110 → Perma-orange TV tier2 layout/reftests/xul/treetwisty-svg-context-paint-1.xul == layout/reftests/xul/treetwisty-svg-context-paint-1-ref.xul | image comparison, max difference: 128, number of differing pixels: 110
Local testing seems to suggest that we're not rendering the twisty image at all in most cases.  (And in the reftest failures here so far, it seems like we tend to be showing the twisty in the testcase but not in the reference case.)

So I think the twisty image isn't blocking onload, so it's unreliable whether it'll be there in the snapshot or not.

Discussed some possible strategies to address this with ntim on IRC, and I think he's working on a fix here.
Assignee: nobody → ntim.bugs
Comment on attachment 8963366 [details]
Bug 1449118 - Force SVGs to load when running the twisty reftest.

https://reviewboard.mozilla.org/r/232280/#review237718

r=me with one nit (please do run this through Try, too)

::: layout/reftests/xul/reftest.list:78
(Diff revision 2)
>  test-pref(svg.context-properties.content.enabled,true) == treetwisty-svg-context-paint-1.xul treetwisty-svg-context-paint-1-ref.xul
> +!= treetwisty-svg-context-paint-1-not-ref.xul treetwisty-svg-context-paint-1-ref.xul

I think you should swap the order of these two lines (i.e. do the "not-ref" comparison *first*, and then the real comparison afterwards)

(The point of the not-ref comparison is to catch images flakily not loading, and that sort of problem is more likely to reveal itself on the first time we load a particular image. So for maximal sensitivity/power, you want the notref comparison to be the first time we try to show these images.)
Attachment #8963366 - Flags: review?(dholbert) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e7b8aee95ed2
Force SVGs to load when running the twisty reftest. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/e7b8aee95ed2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Looks like all the reports in comment 10's link are from 2018-03-27, before the fix landed in comment 8.

So it looks like this is indeed fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.