1449124 - Port bug 1448914 - remove nsISound::playSystemSound

Status: RESOLVED FIXED

(MailNews Core :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1448914 +++

Bug 1448914 comment #0
This API is deprecated (callers are supposed to be using
nsISound::playEventSound instead) and there are no callers remaining in
mozilla-central, or references to the strings for the API.  Let's remove
dead code.

Bug 1448914 comment #2
It's used only by comm-central, but the path is fallback path and it's called with empty string. So, playSystemSound must do nothing. I think that it's fine to remove this API.
https://searchfox.org/comm-central/source/mailnews/base/src/nsStatusBarBiffManager.cpp#142

===

Aceman, do you know something about sounds?

We call it like this, so it's not empty:

  NS_ConvertUTF8toUTF16 utf16SoundURLSpec(soundURLSpec);
  rv = mSound->PlaySystemSound(utf16SoundURLSpec);

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1449124-PlaySystemSound.patch

I guess trying to play a system sound never made a lot of sense.

Comment 2

[:aceman]

Comment on attachment 8962790 [details] [diff] [review]
1449124-PlaySystemSound.patch

Review of attachment 8962790 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, even if we remove this, there is another fallback calling PlayEventSound(nsISound::EVENT_NEW_MAIL_RECEIVED); that should play some generic system "new mail" sound.
Thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/35d17609ae43
Port bug 1448914: Remove use of nsISound::PlaySystemSound. r=aceman