Closed
Bug 1449129
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 10193 - Re-land: "Don't adjust the NavigationTimings on redirects"
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10193 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10193 Details from upstream follow. Kinuko Yasuda <kinuko@chromium.org> wrote: > Re-land: "Don't adjust the NavigationTimings on redirects" > > The reason for revert was the new navigation timing test expectations > (that got commited right before the original change) had a FAIL > expectation for the particular event order that this change was fixing. > > Original change's description: > > Don't adjust the NavigationTimings on redirects > > > > We adjust the timings in WebDocumentLoaderImpl::UpdateNavigation(), > > shouldn't update in each AddRedirect() (which is called in a batch > > way after all the redirects are handled in the browser process with PlzNavigate, > > adjusting timings there with current timestamp is totally wrong) > > > > R=ksakamoto,arthursonzogni > > > > Bug: 813889 > > Change-Id: I3a57d3fdf1833c300feb5ee61737b64cece0946b > > Reviewed-on: https://chromium-review.googlesource.com/974673 > > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#546001} > > Bug: 813889 > Change-Id: I6f5c0ba1196fa1dd52225036820b29a95569ac21 > Reviewed-on: https://chromium-review.googlesource.com/981913 > WPT-Export-Revision: a84f11a67502405e7dc75e139b3fc03dc4531801
Reporter | ||
Updated•6 years ago
|
Component: web-platform-tests → DOM
Product: Testing → Core
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1df64d9295f7acf1e884aa03d94dea15080dd50
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9d2cd64debc4bcbea4b341ffa6e7b4127f39927
Reporter | ||
Updated•6 years ago
|
Priority: P3 → P4
Reporter | ||
Comment 4•6 years ago
|
||
Ran 1 tests and 17 subtests OK : 1 PASS : 17
Updated•6 years ago
|
Priority: P4 → P3
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/0d24098f0a4f [wpt PR 10193] - Re-land: "Don't adjust the NavigationTimings on redirects", a=testonly
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0d24098f0a4f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee | ||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•