144917 - SJIS attachment is mislabeled as ISO-2022-JP when send page from this URL

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect)

Description

[ji]

Build: latest branch build

When sending page from above URL which has charset meta tag specified as x-sjis,
the attachment is mislabeled as ISO-2022-JP, the page is not displayed correctly
in message view page unless it's manually corrected to SJIS from menu.

Steps to reproduce:
1. Go to above URL
2. Select File | Send Page and send it out as a Japanese (ISO-2022-JP) mail
3. After received, observe the attachment display in message view pane.
4. View message source on this mail, the attachment is mislabeled as ISO-2022-JP.

Notes:
1. I don't see this if I save the page to the local drive and send it out as an
attachment, in that case, the attachment is labeled correctly as Shift-JIS.  
2. It also doesn't happen if I send page from http://home.netscape.com/ja
3. The page has meta like:
<meta HTTP-EQUIV='CONTNT-TYPE' CONTENT='text/html; charset=x-sjis' />

Comment 1

[ji]

On that web page, there is JavaScript before charset meta tag, could that cause
the problem?

Comment 2

[nhottanscp]

Does NS6.2 have the problem?

Comment 3

[ji]

With 6.2.3, it's encoded in base64.

Comment 4

[ji]

Discussed this with Naoki, there are two problems here.
1. Parsing problem. This page has charset meta tag, but it's not picked up.
2. Content charset tag problem. In case the attachment doesn't have charset,
like plain text file, or the charset meta tage is not picked up, like this
testing page, "send page" always use the charset specified for mail body.

Nominating for nsbeta1 since it's a regression, the Japanese user may easily
encounter this problem and our client sends out "bad" mails which causes the
display problem to the other mail clients too.

Comment 5

[nhottanscp]

http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgSend.cpp#2276

There is a code which sets main body's charset to non local attachment files. 
That is wrong. We cannot assign mail body's charset for attachment files.
The lines existed before NS6.2, so not sure why NS6.2 not have the problem.
Cc to ducarroz. Jean-Francois, any major changes around attachment handling
since NS6.2?

Comment 6

[nhottanscp]

Attachment: Change not to set the mail charset to attachments. Changed the meta parse function for performance.

Comment 7

[Jean-Francois Ducarroz]

Comment on attachment 84129 [details] [diff] [review]
Change not to set the mail charset to attachments. Changed the meta parse function for performance.

R=ducarroz

Comment 8

[David :Bienvenu]

Comment on attachment 84129 [details] [diff] [review]
Change not to set the mail charset to attachments. Changed the meta parse function for performance.

sr=bienvenu

Comment 9

[nhottanscp]

checked in to the trunk


In comment #4,
>1. Parsing problem. This page has charset meta tag, but it's not picked up.
This problem still exists. But this is not critical as the incorrect label
problem. And Mozilla recognizes the META charset in attachments for display even
not specified as Content-Type charset. This can be filed as a separate bug.

Comment 10

[ji]

Verified as fixed with 05/21 trunk build.
Filed bug 145996 for the charset parsing problem.

Comment 11

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch,pending
Driver's approval.  After, checking in, please add the fixed1.0 keyword.

Comment 12

[scottputterman]

changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1
milestone.  Please get drivers approval before checking in.

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 84129 [details] [diff] [review]
Change not to set the mail charset to attachments. Changed the meta parse function for performance.

please check into the 1.0.1 branch ASAP. once landed remove the 
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword

Comment 14

[nhottanscp]

checked in to 1.0.1

Comment 15

[ji]

verified as fixed with the latest branch build.