1449177 - Crash in java.lang.ClassCastException: android.widget.FrameLayout cannot be cast to org.mozilla.gecko.activitystream.homepanel.stream.StreamOverridablePageIconLayout at org.mozilla.gecko.activitystream.homepanel.stream.WebpageItemRow.<init>(WebpageItem...

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Activity Stream, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-7fb528a3-9bba-4cfe-b8a1-90d560180327.
=============================================================

Seen while looking at crash stats - this signature is new to 59.0.2: https://bit.ly/2IYy2Ae. 

Top 10 frames of crashing thread:

0 libxul.so GeckoAppShellSupport::ReportJavaCrash widget/android/nsAppShell.cpp:276
1 libxul.so mozilla::jni::NativeStub<mozilla::java::GeckoAppShell::ReportJavaCrash_t, GeckoAppShellSupport, mozilla::jni::Args<const mozilla::jni::Ref<mozilla::jni::TypedObject<_jthrowable*>, _jthrowable*>&, const mozilla::jni::StringParam&> >::Wrap<&GeckoAppShellSupport::ReportJavaCrash> widget/android/jni/Natives.h:778
2 dalvik-LinearAlloc (deleted) dalvik-LinearAlloc @0x528a 
3 dalvik-LinearAlloc (deleted) dalvik-LinearAlloc @0x528a 
4 base.odex base.odex@0x909115 
5 dalvik-LinearAlloc (deleted) dalvik-LinearAlloc @0x528a 
6 dalvik-main space (deleted) dalvik-main space @0x1a23e 
7 dalvik-main space (deleted) dalvik-main space @0x60a0de 
8 dalvik-main space (deleted) dalvik-main space @0x63cffe 
9 dalvik-main space (deleted) dalvik-main space @0x5fee66 

=============================================================

Comment 1

[Marcia Knous [:marcia]]

mcomella: Any ideas what might have introduced this?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

No, afaik, this code isn't changing. I'll keep an eye on this.

java.lang.ClassCastException: android.widget.FrameLayout cannot be cast to org.mozilla.gecko.activitystream.homepanel.stream.StreamOverridablePageIconLayout
	at org.mozilla.gecko.activitystream.homepanel.stream.WebpageItemRow.<init>(WebpageItemRow.java:50)
	at org.mozilla.gecko.activitystream.homepanel.StreamRecyclerAdapter.onCreateViewHolder(StreamRecyclerAdapter.java:151)
	at org.mozilla.gecko.activitystream.homepanel.StreamRecyclerAdapter.onCreateViewHolder(StreamRecyclerAdapter.java:51)
	at android.support.v7.widget.RecyclerView$Adapter.createViewHolder(RecyclerView.java:5482)
	at android.support.v7.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:4707)
	at android.support.v7.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:4617)
	at android.support.v7.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:1994)
	at android.support.v7.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1390)
	at android.support.v7.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1353)
	at android.support.v7.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:574)
	at android.support.v7.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:3028)
	at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:2906)
	at android.support.v7.widget.RecyclerView.onLayout(RecyclerView.java:3283)
	at android.view.View.layout(View.java:19692)

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Actually, this is impossible:

It crashes here [1]:

    pageIconLayout = (StreamOverridablePageIconLayout) itemView.findViewById(R.id.page_icon);

But the XML defines page_icon as [2]:

        <org.mozilla.gecko.activitystream.homepanel.stream.StreamOverridablePageIconLayout
                android:id="@+id/page_icon"
                ...

Snorp, you mentioned APK corruption in another inexplicable bug: what did you mean by that? Do we see that often?

I wonder if someone has forked our code base but never bothered to remove our crash reporter.

[1]: https://searchfox.org/mozilla-central/rev/49cc27555d5b7ed2eb06baf156693dd578daa06f/mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/stream/WebpageItemRow.java#50
[2]: https://searchfox.org/mozilla-central/rev/49cc27555d5b7ed2eb06baf156693dd578daa06f/mobile/android/app/src/main/res/layout/activity_stream_webpage_item_row.xml#20

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

I don't know if we see if *often*, but we have seen an alarming number of problems that look like this. We really have no idea what the possible cause could be right now.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking this since it's a new problem in 59 and it seems concerning.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

It sounds like this isn't a regression from bug 1444549 though that's what we first suspected...

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I'm tracking this unexplainable crash and others in bug 1450105.

Comment 8

[Marcia Knous [:marcia]]

Just a quick note this signature is primarily a mix of Samsung, Pixel, and OnePlus devices. Highest % of crashes comes from ONEPLUS A3003 device.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

While this is significant volume, it isn't so high as to drive a dot release for 59 and we don't have a fix or any good leads yet.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.