1449226 - Add better debug information for GPO

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement)

Description

[Mike Kaply [:mkaply]]

For debugging GPO issues, it would be handy if we had the JSON that the GPO generated.

So I'm going to add a debug only output of the JSON after parsing the GPO.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1449226 - Add better debug information for GPO.

Review commit: https://reviewboard.mozilla.org/r/233434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233434/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8964715 [details]
Bug 1449226 - Add better debug information for GPO.

https://reviewboard.mozilla.org/r/233434/#review239470

So, I've been thinking about this.. The issue is that the JSON.stringify() will always run, indepedent if it's going to be logged or not, and that seems a waste to always do this operation.

So, two suggestions:
1 - just keep this patch locally for you
2 - first, check if `log._maxLogLevel == "debug"` to see if this will actually be logged.

Option 2 looks a bit of a hack, but I think it's acceptable, if you think that this will be useful for others.

Comment 3

[Mike Kaply [:mkaply]]

> So, I've been thinking about this.. The issue is that the JSON.stringify() will always run, indepedent if it's going to be logged or not, and that seems a waste to always do this operation.

Good point. I do think this is really useful, especially for testing, so I'll add the check.

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 8964715 [details]
Bug 1449226 - Add better debug information for GPO.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233434/diff/1-2/

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8964715 [details]
Bug 1449226 - Add better debug information for GPO.

https://reviewboard.mozilla.org/r/233434/#review239792

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d070df4285e
Add better debug information for GPO. r=Felipe

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8d070df4285e

Comment 8

[Mike Kaply [:mkaply]]

Comment on attachment 8964715 [details]
Bug 1449226 - Add better debug information for GPO.

Approval Request Comment
[Feature/Bug causing the regression]: Improve debugging for GPO
[User impact if declined]: Difficult for test to debug HPO
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Non
[Is the change risky?]: No
[Why is the change risky/not risky?]: Debug only
[String changes made/needed]:

I know this seems a weird one for uplift, but it's very helpful when we're debugging the GPO code.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8964715 [details]
Bug 1449226 - Add better debug information for GPO.

Make GPO debugging easier for the policy engine work. Approved for 60.0b11.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8495b5dc53c7