Closed
Bug 1449296
Opened 6 years ago
Closed 6 years ago
Make gdb/run-tests.py runnable with either Python 2 or 3
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
Details
Attachments
(1 file)
|
7.13 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
We are sort of kind of converting most Python 2 scripts to either Python 3 or both.
|
Assignee | |
Comment 1•6 years ago
|
||
It's simple enough to make this work in both.
Attachment #8962845 -
Flags: review?(jwalden+bmo)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8962845 [details] [diff] [review] Make gdb/run-tests.py runnable with either Python 2 or 3 Review of attachment 8962845 [details] [diff] [review]: ----------------------------------------------------------------- Stealing. ::: js/src/gdb/run-tests.py @@ +186,5 @@ > def onTimeout(self): > self.summary.timeout(self) > > def show_cmd(self, out): > + print("Command: ", make_shell_cmd(self.cmd())) The output from this will be weird in Python2. The % operator would be better here.
Attachment #8962845 -
Flags: review?(jwalden+bmo) → review+
|
|
||
Updated•6 years ago
|
Priority: -- → P3
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/80f331e70605 Make gdb/run-tests.py runnable with either Python 2 or 3, r=jorendorff
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/80f331e70605
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•