1449342 - Mono sound only plays on left side

Status: VERIFIED FIXED

(Core :: Audio/Video: cubeb, defect, P2)

Description

[Martin Giger [:freaktechnik]]

Attachment: aboutsupport-media.png

Since about a week mono audio tracks of Twitch streams (haven't been able to verify if it affects anything else) only play on the left side. This is not reproducing in release and stereo tracks play fine.

This also rules out a site issue or a configuration issue with the audio mixer.

Example recording this reproduces with: https://www.twitch.tv/videos/242812649

Comment 1

[Martin Giger [:freaktechnik]]

This also reproduces with YouTube videos with mono audio tracks: https://www.youtube.com/watch?v=jMfmjqMIT3A

Comment 2

[Jean-Yves Avenard [:jya]]

Another reason to not let pulse perform the mixing... it does so poorly

Comment 3

[Jean-Yves Avenard [:jya]]

actually, this would be in the cubeb-rust component.

Dan, could you have a look?

thank you

Comment 4

[u480271]

Ok, I'll investigate.

Comment 5

[Jan Kokemüller]

Attachment: cubeb-pulse-rs-mono-fix.patch

Would the attached patch fix the issue? I've tested it successfully with mono and stereo files.

Comment 6

[Jean-Yves Avenard [:jya]]

Yes..

However, we have a fix pending...
https://github.com/djg/cubeb-pulse-rs/commit/55ce985ad6c53049355907e3df09f172827aecfd

Comment 7

[u480271]

Attachment: Bug 1449342 - Update cubeb-pulse-rs to commit 55ce985.

Pull in fix for cubeb channel layout to PulseAudio channel layout.

Review commit: https://reviewboard.mozilla.org/r/233184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233184/

Comment 8

[Matthew Gregan [:kinetik]]

Comment on attachment 8964453 [details]
Bug 1449342 - Update cubeb-pulse-rs to commit 55ce985.

https://reviewboard.mozilla.org/r/233184/#review238648

Comment 9

[u480271]

Tested with https://www.youtube.com/watch?v=jMfmjqMIT3A Output is balanced in stereo headphones.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26db288c5466
Update cubeb-pulse-rs to commit 55ce985. r=kinetik

Comment 11

[Asa Dotzler [:asa]]

I've got a user on 60 beta describing similar symptoms starting in a similar time frame. Does this bug impact 60 beta? If so, do we need to uplift the fix there? If not, should I file a new bug on beta having a similar problem?

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/26db288c5466

Comment 13

[Jean-Yves Avenard [:jya]]

(In reply to Asa Dotzler [:asa] from comment #11)
> I've got a user on 60 beta describing similar symptoms starting in a similar
> time frame. Does this bug impact 60 beta? If so, do we need to uplift the
> fix there? If not, should I file a new bug on beta having a similar problem?

no... the changes that caused the regression on linux was only made in 61.

Comment 14

[Edmond]

I'm running Firefox 61.0 on OS X and since the update to 61 I am experiencing mono output going to the left speaker only.

Comment 15

[Matthew Gregan [:kinetik]]

(In reply to Edmond from comment #14)
> I'm running Firefox 61.0 on OS X and since the update to 61 I am
> experiencing mono output going to the left speaker only.

This bug is for a Linux-specific issue.  For macOS, bug 1469152 likely covers the issue you're experiencing.

Comment 16

[João Lopes]

(In reply to Dan Glastonbury (:kamidphish) | needinfo me from comment #9)
> Tested with https://www.youtube.com/watch?v=jMfmjqMIT3A Output is balanced
> in stereo headphones.

Tested with this video and the issue is still present. Running Nightly 61.0a1, Ubuntu 16.04.

Comment 17

[Martin Giger [:freaktechnik]]

(In reply to João from comment #16)
> Running Nightly 61.0a1, Ubuntu 16.04.

Current nightly would be 64.0a1, you may want to update.