Closed
Bug 1449367
Opened 7 years ago
Closed 7 years ago
Increase DevTools error sample rate
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jlast, Assigned: osmose)
References
Details
Attachments
(1 file)
It would be nice to see if we can increase the sample rate for devtools and the devtools debugger.
The rationale is that DevTools received a fraction of the traffic, therefore it should have a higher sample rate to have meaningful errors.
Assignee | ||
Comment 1•7 years ago
|
||
The way I'm planning on doing this is filtering errors by the file they're thrown from (i.e. the topmost frame in the stack) and applying a different sample rate than usual if the path starts with chrome://devtools. Would that cover the code that you want increased error reporting for?
Flags: needinfo?(jlaster)
`resource://devtools` is another common prefix that should get similar treatment to `chrome://devtools`.
Summary: Increase Devtools error sample rate → Increase DevTools error sample rate
Reporter | ||
Comment 3•7 years ago
|
||
Yep, chrome://devtools and resource://devtools would work.
Flags: needinfo?(jlaster)
Comment 4•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → mkelly
Product: Socorro → Firefox
Assignee | ||
Updated•7 years ago
|
Attachment #8964389 -
Flags: review?(jryans)
Comment 5•7 years ago
|
||
Comment on attachment 8964389 [details]
Bug 1449367: Use 100% sample rate for devtools error reports.
J. Ryan Stinnett [:jryans] (use ni?) has approved the revision.
https://phabricator.services.mozilla.com/D835
Attachment #8964389 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Attachment #8964389 -
Flags: review?(jryans)
Assignee | ||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddfbc4e4891c07c71a2ff7c82b46d1cedf0282de
Bug 1449367: Use 100% sample rate for devtools error reports. r=jryans
Comment 7•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•