1449370 - Missing icons on https://ffbans.org/

Status: RESOLVED DUPLICATE of bug 1434801

(Core :: Graphics: WebRender, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

See https://i.imgur.com/qkjdUps.png

Comment 1

[Aria Beingessner [:Gankra]]

Confirmed it happens on (at least) mac and windows 10.

Comment 2

[Darkspirit]

Attachment: Screenshot_20180328_173619.png

Comment 3

[Darkspirit]

Reported via https://www.reddit.com/r/firefox/comments/87mrxy/webrender_feedback_march_edition/dwe12is/.

-----

mozregression --repo autoland --launch 5f6417128acb05b280c3c59a611e605458214dfd --pref layers.acceleration.force-enabled:true gfx.webrender.all:true gfx.webrender.enabled:true gfx.webrender.blob-images:true image.mem.shared:true layout.display-list.retain:false startup.homepage_welcome_url:"https://ffbans.org/"
good

mozregression --repo autoland --launch 4d8fbb071d0ef1951b05873bf6dfb797645c2a99 --pref layers.acceleration.force-enabled:true gfx.webrender.all:true gfx.webrender.enabled:true gfx.webrender.blob-images:true image.mem.shared:true layout.display-list.retain:false startup.homepage_welcome_url:"https://ffbans.org/"
bad: icons are partially visible

-> Same regression range as bug 1432685.

But it became worse. Searching for the moment when icons became completely invisible:
mozregression --good 2018-01-17 --bad 2018-03-27 --pref gfx.webrender.all:true startup.homepage_welcome_url:"https://ffbans.org/"
> 9:50.18 INFO: Last good revision: e458f8679b88977f8f171b0d5c4b75b50f425832
> 9:50.18 INFO: First bad revision: f53e340b051cec79c3dab594fe87e8e805ba2fab
> 9:50.18 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e458f8679b88977f8f171b0d5c4b75b50f425832&tochange=f53e340b051cec79c3dab594fe87e8e805ba2fab

> f53e340b051c	Nicolas Silva — Bug 1436058 - Don't remove a WebRender pipeline if we re-created one with the same id. r=kats
> a408b8f2f7ab	Nicolas Silva — Bug 1436058 - Remove async image pipelines when the renderer notifies pipelines removed. r=kats
> cacc7bcb3220	Kartikaya Gupta — Bug 1436058 - Update for log 0.4 bump in WR PR 2385. r=jrmuizel
> 9cca7938b734	Kartikaya Gupta — Bug 1436058 - Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
> a4dc76286299	Kartikaya Gupta — Bug 1436058 - Update webrender to 342bc314db94aa439b2001249c5f24ccfcbccc22. r=jrmuizel
> 9bc3906d3dc9	Andreas Tolfsen — Bug 1375637 - Make test_async_script_timeout less likely to fail. r=automatedtester

Try builds are gone.
https://github.com/servo/webrender/compare/08e49649f1fc9cacff4e10ebc390babcea752236...342bc314db94aa439b2001249c5f24ccfcbccc22

Comment 4

[Aria Beingessner [:Gankra]]

Oh, nice, yeah this looks like exactly the same issue as bug 1432685 (sometimes while scrolling I see the icons "wipe" in.

Note also that some "icons" are actually text (font packed with icons), and some are actually images. Probably means this is a clipscroll issue. I have made a reduced capture of the page and am investigating.

Comment 6

[Aria Beingessner [:Gankra]]

The bug appears to be that we're wildly mishandling drop-shadows in iframes in webrender (and we implement the chrome/content seperation with an iframe, so every firefox page has that property).

Filed upstream with a test-case.