Closed
Bug 1449483
Opened 6 years ago
Closed 6 years ago
Update password manager ensure origin code to use a real origin
Categories
(Calendar :: Internal Components, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
6.2
People
(Reporter: Fallen, Assigned: Fallen)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.46 KB,
patch
|
Fallen
:
review+
Fallen
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
The ensureOrigin function turns https://example.com into https://example.com/ which is not what the login manager accepts. I'm fixing that to always return prePath, which is indeed the origin. The code says it can be removed now, but I believe I didn't actually release a new gdata version in the meanwhile, so the comment is still relevant. The usual paradoxon regarding temporary code in software projects :)
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8963016 -
Flags: review?(makemyday)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8963016 -
Attachment description: bug-1449483-update-password-manager-ensure-origin-code-to-use-a-real-origin.diff → Fix - v1
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8963016 [details] [diff] [review] Fix - v1 Review of attachment 8963016 [details] [diff] [review]: ----------------------------------------------------------------- looks good - your mentioning that it can be removed after 6.2, is this for c-b only, since c-c is 6.3 already?
Attachment #8963016 -
Flags: review?(makemyday) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Let's add this for c-b and c-c for now. I'll remove this once I do the gdata release.
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•6 years ago
|
||
Attachment #8963016 -
Attachment is obsolete: true
Attachment #8967871 -
Flags: review+
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8967871 -
Flags: approval-calendar-beta+
Pushed by mozilla@kewis.ch: https://hg.mozilla.org/comm-central/rev/56a8323d4235 Update password manager ensure origin code to use a real origin. r=MakeMyDay
|
|
Assignee | |
Comment 6•6 years ago
|
||
https://hg.mozilla.org/releases/comm-beta/rev/33a67b0129b3
Target Milestone: --- → 6.2
You need to log in
before you can comment on or make changes to this bug.
Description
•