1449570 - very laggy bookmark interactions with sync running

Status: RESOLVED DUPLICATE of bug 1536170

(Firefox :: Sync, defect, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

While investigating a bug that required me to use bookmarks in 60 beta branch I opened I noticed a bad interaction with firefox sync.  What happened:

1. Open dev-edition after not using it for a long time.
2. Open site and click bookmark button.  Bookmark button does nothing.  Try this a couple times.
3. Open sidebar.  It opens, but I can't interact with any of my bookmark entries.
4. Eventually I get a few duplicate entries for the site I was trying to bookmark in (2).
5. Try to delete one by right-clicking in sidebar, but it takes a 30+ seconds for it to disappear.
6. After sync completes bookmark interactions go back to normal.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

I had a bit of a look at this via the script in bug 1168428, and while I could reproduce *some* jank, nothing anywhere near as bad as what is being reported here. I'll keep my needinfo to try and see what I can come up with using a much larger set of data to apply from the server, but I doubt I'll get to that for a week or 2.

And FWIW, after chatting with Thom, it seems that the jank I *did* measure seems to be related mostly to garbage collection, which in-turn seems to imply that we are creating a large number of temp objects for a large sync, many of which seem to be promises :/ However, I was seeing a number of times the jank was in the order of 8ms, so still no where near large enough to account for the symptoms described here.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Much of the jank reported here was hopefully fixed in bug 1536170 and I've no plans to dig deeper at the moment. We haven't had many recent reports along these lines, but let's keep the bug open a little longer before closing it.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Haven't seen this reported, nor experienced it myself, since bug 1536170