Closed
Bug 1449571
Opened 8 years ago
Closed 8 years ago
Re-enable JS_CRASH_DIAGNOSTICS on ASan builds
Categories
(Core :: JavaScript Engine, enhancement, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
759 bytes,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Bug 1082988 disabled this because it broke ASan on Windows.
However, it's 4 years later now and I think we should try this again. If this still fails on Windows, we can disable it *only on Windows*.
Ehsan, does that sound reasonable?
Attachment #8963124 -
Flags: review?(ehsan)
|
Assignee | |
Comment 1•8 years ago
|
||
Linux64-asan is green with this: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0156662635aee92df1c4725ce429699e9f0c01c8&group_state=expanded
|
||
Updated•8 years ago
|
status-firefox61:
--- → affected
Priority: -- → P2
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8963124 [details] [diff] [review]
Patch
Review of attachment 8963124 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8963124 -
Flags: review?(ehsan) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b653c3d140d
Re-enable JS_CRASH_DIAGNOSTICS on ASan builds. r=ehsan
|
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•