Re-enable JS_CRASH_DIAGNOSTICS on ASan builds

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P2
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

Posted patch PatchSplinter Review
Bug 1082988 disabled this because it broke ASan on Windows.

However, it's 4 years later now and I think we should try this again. If this still fails on Windows, we can disable it *only on Windows*.

Ehsan, does that sound reasonable?
Attachment #8963124 - Flags: review?(ehsan)
Blocks: 1448589
Priority: -- → P2
Comment on attachment 8963124 [details] [diff] [review]
Patch

Review of attachment 8963124 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8963124 - Flags: review?(ehsan) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b653c3d140d
Re-enable JS_CRASH_DIAGNOSTICS on ASan builds. r=ehsan
https://hg.mozilla.org/mozilla-central/rev/1b653c3d140d
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.