Closed Bug 1449571 Opened 3 years ago Closed 3 years ago

Re-enable JS_CRASH_DIAGNOSTICS on ASan builds

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Bug 1082988 disabled this because it broke ASan on Windows.

However, it's 4 years later now and I think we should try this again. If this still fails on Windows, we can disable it *only on Windows*.

Ehsan, does that sound reasonable?
Attachment #8963124 - Flags: review?(ehsan)
Blocks: 1448589
Priority: -- → P2
Comment on attachment 8963124 [details] [diff] [review]
Patch

Review of attachment 8963124 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8963124 - Flags: review?(ehsan) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b653c3d140d
Re-enable JS_CRASH_DIAGNOSTICS on ASan builds. r=ehsan
https://hg.mozilla.org/mozilla-central/rev/1b653c3d140d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.