Closed
Bug 1449606
Opened 8 years ago
Closed 8 years ago
Searchfox doesn't linkify "Bug NNNN" text in .py files
Categories
(Webtools :: Searchfox, enhancement)
Webtools
Searchfox
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: away, Assigned: kats)
Details
|
Assignee | |
Comment 1•8 years ago
|
||
The triple-quoted string is treated as a string literal [1] which doesn't get linkified. But maybe we should linkify those. URLs in string literals in code for example might be good to linkify as well.
[1] https://github.com/mozsearch/mozsearch/blob/fb9bef4d31dbbacd027ef76c82581b3a3f31e782/tools/src/tokenize.rs#L455
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://github.com/mozsearch/mozsearch/blob/fb9bef4d31dbbacd027ef76c82581b3a3f31e782/tools/src/format.rs#L197 <- updating this condition to also allow TokenKind::StringLiteral should be sufficient to fix this.
|
|
Assignee | |
Comment 3•8 years ago
|
||
Assignee: nobody → bugmail
|
|
Assignee | |
Comment 4•8 years ago
|
||
This is deployed now.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Is this expected to cover .ini files too? Should I file a new bug? https://searchfox.org/mozilla-central/rev/f860c2bf00576959b07e2d9619c7b5088b0005be/devtools/client/memory/test/browser/browser.ini#18
Flags: needinfo?(bugmail)
|
|
Assignee | |
Comment 7•8 years ago
|
||
No, it doesn't cover .ini files - please file a new bug. I'm not sure offhand if we run the searchfox tokenizer on those and which codepath it goes through.
Flags: needinfo?(bugmail)
Filed bug 1451742
You need to log in
before you can comment on or make changes to this bug.
Description
•