Closed Bug 1449624 Opened 4 years ago Closed 4 years ago
Single-locale builds are all in English
59 bytes, text/x-review-board-request
It seems that the Nightly single-locale builds are all in English for at least a week now (https://ftp.mozilla.org/pub/mobile/nightly/latest-mozilla-central-android-api-16-l10n/)
Oh right -- I forgot to follow-up with the tweak from Bug 1443208. Let me get that reviewed here.
Depends on: 1443208
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Comment on attachment 8963259 [details] Bug 1449624 - Make single-locale repacks use correct locale. https://reviewboard.mozilla.org/r/232122/#review238060
Attachment #8963259 - Flags: review+
Attachment #8963259 - Flags: review?(core-build-config-reviews)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/eed14f951a09 Make single-locale repacks use correct locale. r=mshal
Backout by email@example.com: https://hg.mozilla.org/mozilla-central/rev/44aceee694be Backed out changeset eed14f951a09 for Android Nightly bustages a=backout
Backed out changeset eed14f951a09 (bug 1449624) for Android Nightly bustages a=backout Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=b7fa9d95150ec24e3c8d11106153f76be4507356&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-resultStatus=pending&filter-resultStatus=running&selectedJob=171189046 Backout: https://hg.mozilla.org/mozilla-central/rev/44aceee694bec3dc6a7757395d25553ae87ab166
Seems like these are still broken. I've been contacted by various localization teams that are unable to validate their work and therefore are on hold for shipping. Do we have an approx. ETA for getting a fix in? It's been a few weeks that we're unable to test any of these languages up on single-locale. Thanks!
(In reply to Delphine Lebédel [:delphine - use Need Info] from comment #8) > Seems like these are still broken. I've been contacted by various > localization teams that are unable to validate their work and therefore are > on hold for shipping. Do we have an approx. ETA for getting a fix in? > It's been a few weeks that we're unable to test any of these languages up on > single-locale. Thanks! Oh -- I forgot that this bounced. I'll take another look before EOD and update this ticket by EOD tomorrow.
Ah, l10n. This turned out to be a frustrating chase, which I will summarize here. Everything looked like it was working... except the final MERGE_RELATIVE_FILES produces the wrong result. Why is that? Because l10n.mk isn't included in just the right way in m/a/base/Makefile.in. Why not? Because l10n.mk is subtly connected to the whole "shadow locales/" directory thing. So it all means that we can either have "correct l10n" or "correct Make dependencies", and this whole patch series has been pushing for correct Make dependencies. The whole edifice needs to burn in a fire. The fix, however, is simple: just pass more of the guts of l10n.mk into the sub-Make. With that, https://treeherder.mozilla.org/#/jobs?repo=try&revision=25183a5b84a586ad27ab00ef4fd642383000bdf2 is green and I'm going to land this.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/c24f27ca8573 Make single-locale repacks use correct locale. r=mshal
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 61 → mozilla61
You need to log in before you can comment on or make changes to this bug.