Closed Bug 1449625 Opened 2 years ago Closed 2 years ago

Perma devtools/client/inspector/markup/test/browser_markup_events_click_to_close.js and animation inspector failures when Gecko 61 merges to Beta on 2018-04-26

Categories

(DevTools :: Inspector: Animations, defect)

defect
Not set

Tracking

(firefox-esr52 unaffected, firefox59 unaffected, firefox60 unaffected, firefox61+ verified)

VERIFIED FIXED
Firefox 61
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 + verified

People

(Reporter: aryx, Assigned: daisuke)

References

Details

Attachments

(2 files, 3 obsolete files)

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=62bc5d759b4fd7f690e227f15118c961acf30701&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=170821887

Log markup failure: https://treeherder.mozilla.org/logviewer.html#?job_id=170821887&repo=try

[task 2018-03-28T15:37:42.757Z] 15:37:42     INFO - TEST-PASS | devtools/client/inspector/markup/test/browser_markup_events_click_to_close.js | Found markup-container for selector: #d2 - 
[task 2018-03-28T15:37:42.758Z] 15:37:42     INFO - Click the event icon for the first element
[task 2018-03-28T15:37:42.854Z] 15:37:42     INFO - event tooltip for the first div is shown
[task 2018-03-28T15:37:42.856Z] 15:37:42     INFO - Click the event icon for the second element
[task 2018-03-28T15:37:42.894Z] 15:37:42     INFO - previous tooltip hidden
[task 2018-03-28T15:37:42.962Z] 15:37:42     INFO - event tooltip for the second div is shown
[task 2018-03-28T15:37:42.962Z] 15:37:42     INFO - Click on the animation inspector tab
[task 2018-03-28T15:37:42.971Z] 15:37:42     INFO - TEST-INFO | started process screentopng
[task 2018-03-28T15:37:43.486Z] 15:37:43     INFO - TEST-INFO | screentopng: exit 0
[task 2018-03-28T15:37:43.486Z] 15:37:43     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_events_click_to_close.js | Uncaught exception - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:505 - TypeError: aTarget is null
[task 2018-03-28T15:37:43.486Z] 15:37:43     INFO - Stack trace:
[task 2018-03-28T15:37:43.487Z] 15:37:43     INFO -     synthesizeMouseAtCenter@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:505:7
[task 2018-03-28T15:37:43.487Z] 15:37:43     INFO -     @chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_events_click_to_close.js:62:3
[task 2018-03-28T15:37:43.487Z] 15:37:43     INFO -     Tester_execTest@chrome://mochikit/content/browser-test.js:1067:9
[task 2018-03-28T15:37:43.488Z] 15:37:43     INFO -     Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:967:9
[task 2018-03-28T15:37:43.489Z] 15:37:43     INFO -     SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59

Log animation inspector failures (many failures): https://treeherder.mozilla.org/logviewer.html#?job_id=170821875&repo=try
Flags: needinfo?(dakatsuka)
I'm sorry, I'll fix soon!
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c92d013594e61457441a4de017c7b1e7dc6e4631
Assignee: nobody → dakatsuka
Flags: needinfo?(dakatsuka)
Attachment #8963390 - Attachment is obsolete: true
Attachment #8963390 - Flags: review?(gl)
Thank you and I'm sorry, Sebastian.
We still needed the pref for new animation inspector in the tests on beta.

By the way, how can I test the beta on try-server??
Flags: needinfo?(dakatsuka)
> By the way, how can I test the beta on try-server??
1. Go to the document which lists the beta simulations at https://docs.google.com/document/d/1fzp30VHOoMy0hqtL0MR0PPJFGwu6Bv_WnBeqcmJ04Yk/edit#
2. Open the latest Early Beta push.
3. In the document, get the base mozilla-central revision for the simulation.
4. Check if Treeherder shows that revision on your push. If yes, import the patches above that one (bottom to top). If no, import all of the patches shown (from bottom to top). The "base config" and "early beta" one are always used, the other ones build and test fixes for current issues which haven't landed yet.
Comment on attachment 8964079 [details]
Bug 1449625 - Part 1: Use computed view instad of animatoin inspector.

https://reviewboard.mozilla.org/r/232870/#review238506

::: commit-message-6aa3b:1
(Diff revision 1)
> +Bug 1449625 - Part 1: Use computed view instad of animatoin inspector. r?gl

Typos

Select the computed view instead of animation inspector in browser_markup_events_click_to_close.js test.
Comment on attachment 8964079 [details]
Bug 1449625 - Part 1: Use computed view instad of animatoin inspector.

https://reviewboard.mozilla.org/r/232870/#review238508
Attachment #8964079 - Flags: review?(gl) → review+
Comment on attachment 8964080 [details]
Bug 1449625 - Part 2: Turn on new animation inspector for beta tests.

https://reviewboard.mozilla.org/r/232872/#review238510
Attachment #8964080 - Flags: review?(gl) → review+
Attachment #8964079 - Attachment is obsolete: true
Attachment #8964080 - Attachment is obsolete: true
Mmmm,,, the r+ were cleared again..
I'll land to the inbound.
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5914a9266e67
Part 1: Select the computed view instead of animation inspector in browser_markup_events_click_to_close.js test. r=gl
https://hg.mozilla.org/integration/mozilla-inbound/rev/3bfef84a8b62
Part 2: Turn on new animation inspector for beta tests. r=gl
Comment on attachment 8964428 [details]
Bug 1449625 - Part 1: Select the computed view instead of animation inspector in browser_markup_events_click_to_close.js test.

https://reviewboard.mozilla.org/r/233166/#review238658
Attachment #8964428 - Flags: review?(gl) → review+
Comment on attachment 8964429 [details]
Bug 1449625 - Part 2: Turn on new animation inspector for beta tests.

https://reviewboard.mozilla.org/r/233168/#review238660
Attachment #8964429 - Flags: review?(gl) → review+
https://hg.mozilla.org/mozilla-central/rev/5914a9266e67
https://hg.mozilla.org/mozilla-central/rev/3bfef84a8b62
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.