1449640 - Don't compute a scale for 3d transformed content

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1449640. Don't compute a scale for 3d transformed content.

This matches the behaviour of ChooseScaleAndSetTransform()

Review commit: https://reviewboard.mozilla.org/r/232204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232204/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8963300 [details]
Bug 1449640. Don't compute a scale for 3d transformed content.

https://reviewboard.mozilla.org/r/232204/#review237676

ChooseScaleAndSetTransform, my old nemesis. I never did understand that code, and I don't really understand this. But if it passes tests, r+

::: gfx/layers/wr/StackingContextHelper.cpp:18
(Diff revision 1)
>  namespace layers {
>  
>  StackingContextHelper::StackingContextHelper()
>    : mBuilder(nullptr)
>    , mScale(1.0f, 1.0f)
>    , mAffectsClipPositioning(false)

This constructor should initialize mIsPreserve3D also

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8963300 [details]
Bug 1449640. Don't compute a scale for 3d transformed content.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232204/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d30ebcdc5ac
Don't compute a scale for 3d transformed content. r=kats

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/4d30ebcdc5ac

Comment 7

[Timothy Nikkel (:tnikkel)]

Adding a test for this in bug 1626865.