1449641 - Small tweaks for BasicCompositor

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement, P3)

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1449641 - Use the correct parameter when computing the clear rect.

This was incorrectly using the invalid rect, so it was clearing more than
necessary and not taking advantage of the opaque region that the caller computes.
The idea is that we don't need to clear parts of the invalid region that will be
covered by something opaque.

Review commit: https://reviewboard.mozilla.org/r/232132/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232132/

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1449641 - Remove extraneous "if (mRenderTarget->mDrawTarget != mDrawTarget)".

The same condition is checked just before this if, so it's always true.

Review commit: https://reviewboard.mozilla.org/r/232134/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232134/

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1449641 - Always use mDrawTarget when merging the buffered region into the window DrawTarget.

If we have a non-null mTarget, we already set mDrawTarget to mTarget. So "mTarget ? mTarget : mDrawTarget" will always evaluate to mDrawTarget.

Review commit: https://reviewboard.mozilla.org/r/232144/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232144/

Comment 4

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8963251 [details]
Bug 1449641 - Use the correct parameter when computing the clear rect.

https://reviewboard.mozilla.org/r/232132/#review237782

Comment 5

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8963252 [details]
Bug 1449641 - Remove extraneous "if (mRenderTarget->mDrawTarget != mDrawTarget)".

https://reviewboard.mozilla.org/r/232134/#review237784

Comment 6

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8963256 [details]
Bug 1449641 - Always use mDrawTarget when merging the buffered region into the window DrawTarget.

https://reviewboard.mozilla.org/r/232144/#review237786

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfc4cc67701f
Use the correct parameter when computing the clear rect. r=sotaro
https://hg.mozilla.org/integration/autoland/rev/ac980a443965
Remove extraneous "if (mRenderTarget->mDrawTarget != mDrawTarget)". r=sotaro
https://hg.mozilla.org/integration/autoland/rev/67fabb2e4990
Always use mDrawTarget when merging the buffered region into the window DrawTarget. r=sotaro

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cfc4cc67701f
https://hg.mozilla.org/mozilla-central/rev/ac980a443965
https://hg.mozilla.org/mozilla-central/rev/67fabb2e4990

Comment 9

[Ionuț Goldan [:igoldan]]

Perf wins!

== Change summary for alert #12632 (as of Tue, 10 Apr 2018 00:32:16 GMT) ==

Improvements:

  2%  tart linux64 pgo e10s stylo     2.01 -> 1.96
  2%  tart linux64 opt e10s stylo     2.15 -> 2.11

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=12632

Comment 10

[Markus Stange [:mstange]]

Cool! Probably from the first patch, which made an existing botched optimization actually take effect.