Closed Bug 1449707 Opened 4 years ago Closed 4 years ago

Port bug 1417883 and bug 1423757 to TB

Categories

(Thunderbird :: Theme, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 61.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files, 2 obsolete files)

bug 1417883: Allow theming autocomplete popups.

This implements the ability of colouring the autocomplete popups and content like we have in the gloda search.

bug 1423757: Allow theming toolbar fields focused state.

This implements the ability of colouring the input fields like the search box when they are focused.
Attached patch theme-autocomplete-fields.patch (obsolete) — Splinter Review
To correctly work this patch needs the m-c revision 1c8dd93fbeb0.

This patch is a port of https://hg.mozilla.org/mozilla-central/rev/e811edda21f3
and https://hg.mozilla.org/mozilla-central/rev/2151edc10e9e

The changeset https://hg.mozilla.org/mozilla-central/rev/a1fae6d6cca4 changed the ThemeVariableMap.jsm to make it possible to create dependent colours like the --autocomplete-popup-secondary-color. We don't use it and I haven't copied this part.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8963328 - Flags: review?(jorgk)
Attached file test-webext-theme.xpi
Test theme for testing the new possibilities.

The focused fields, the searchbar, inverts now it's colours and has a red border. The autocomplete popup, the one of the gloda search has a green background with red and blue text. When using the keyboard up/down arrows the selected item turns to yellow background with dark gray text.
Attached patch theme-autocomplete-fields.patch (obsolete) — Splinter Review
Updated patch with following follow-up bugs:

Bug 1449324 Autocomplete popup border is not affected by the popup_border property. https://hg.mozilla.org/integration/autoland/rev/0f08cc27225c
This paints the autocomplete popup border.
and

Bug 1449765 Fix urlbar focusring on macOS. https://hg.mozilla.org/integration/autoland/rev/3aa7da8fa078
On Windows you see no difference to the former patch.
Attachment #8963328 - Attachment is obsolete: true
Attachment #8963328 - Flags: review?(jorgk)
Attachment #8963739 - Flags: review?(jorgk)
Comment on attachment 8963739 [details] [diff] [review]
theme-autocomplete-fields.patch

Thank you, I tried it and it works.

The QFB text box is traditionally different to the Gloda text box. However, the QFB text box also gets a red border with the test theme ("toolbar_field_border_focus": "#f00"), so it follows a tiny bit of the theme. Is that intentional?
Attachment #8963739 - Flags: review?(jorgk) → review+
(In reply to Jorg K (GMT+1) from comment #4)
> Comment on attachment 8963739 [details] [diff] [review]
> theme-autocomplete-fields.patch
> 
> Thank you, I tried it and it works.
> 
> The QFB text box is traditionally different to the Gloda text box. However,
> the QFB text box also gets a red border with the test theme
> ("toolbar_field_border_focus": "#f00"), so it follows a tiny bit of the
> theme. Is that intentional?

This wasn't intentional. Fixed.
Attachment #8963739 - Attachment is obsolete: true
Attachment #8964188 - Flags: review?(jorgk)
Comment on attachment 8964188 [details] [diff] [review]
theme-autocomplete-fields.patch

I'm glad I asked ;-)
Attachment #8964188 - Flags: review?(jorgk) → review+
Me too. :-)
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9335b650974e
Port bug 1417883 and bug 1423757 to TB (theming improvements). r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
I checked it in with s/this boxes/these boxes/ :-)
Target Milestone: --- → Thunderbird 61.0
You need to log in before you can comment on or make changes to this bug.