Closed Bug 1449737 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 10223 - Revert "bluetooth: FakeBluetoothChooser impl."

Categories

(Testing :: web-platform-tests, defect, P4)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 10223 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10223
Details from upstream follow.

François Doray <fdoray@chromium.org> wrote:
>  Revert "bluetooth: FakeBluetoothChooser impl."
>  
>  This reverts commit 188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7.
>  
>  Reason for revert: https://crbug.com/826787
>  
>  Original change's description:
>  > bluetooth: FakeBluetoothChooser impl.
>  >
>  > Implements the interfaces that FakeBluetoothChooser overrides. The
>  > mojom::FakeBluetoothChooser overrides are implemented by running
>  > |event_handler_| with the appropriate arguments. The BluetoothChooser
>  > overrides do nothing at the moment, since the base class is only meant
>  > to update the chooser user interface.
>  >
>  > This change also begins to partially convert a Bluetooth chooser test to test
>  > the interface and deletes the temporary tests that were created to test this
>  > API.
>  >
>  > BUG=719827,719826,824704
>  >
>  > Change-Id: I56a04e6bdb2de38d9163d7bc350db578deeb9ba3
>  > Reviewed-on: https://chromium-review.googlesource.com/962983
>  > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
>  > Reviewed-by: Conley Owens <cco3@chromium.org>
>  > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
>  > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#546509}
>  
>  TBR=dcheng@chromium.org,cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org
>  
>  Change-Id: I0597151ec5878d41ac631b72296203bc99b1f2c8
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 719827, 719826, 824704, 826787
>  Reviewed-on: https://chromium-review.googlesource.com/984299
>  Commit-Queue: François Doray <fdoray@chromium.org>
>  Reviewed-by: François Doray <fdoray@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#546572}
>
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5d8e8a1bde7
[wpt PR 10223] - Revert "bluetooth: FakeBluetoothChooser impl.", a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.