Closed Bug 1449759 Opened 3 years ago Closed 3 years ago

Write an APZ mochitest for bug 1443518

Categories

(Core :: Panning and Zooming, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: botond, Assigned: botond)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

In bug 1443518 we fixed a Layout bug that caused APZ hit testing to produce incorrect results.

This bug tracks adding an APZ mochitest for that scenario.
Comment on attachment 8963386 [details]
Bug 1449759 - Add an APZ mochitest for bug 1443518.

https://reviewboard.mozilla.org/r/232292/#review237734

That hitTestScrollbar function sure is handy!

::: gfx/layers/apz/test/mochitest/helper_hittest_float_bug1443518.html:11
(Diff revision 1)
> +  <script type="application/javascript" src="apz_test_native_event_utils.js"></script>
> +  <script type="application/javascript" src="/tests/SimpleTest/paint_listener.js"></script>
> +  <meta name="viewport" content="width=device-width"/>
> +  <style>
> +    #div1 {
> +    	position: relative;

there appear to be some tabs here? MozReview is showing red
Attachment #8963386 - Flags: review?(bugmail) → review+
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #2)
> there appear to be some tabs here? MozReview is showing red

One of these days, I'll beat all the editors I use on all my computers into respecting Mozilla's whitespace rules...
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #2)
> That hitTestScrollbar function sure is handy!

Yeah, I love it :) Thanks for figuring out the calculations needed to get it to work, it's really helping us expand our test coverage!
https://hg.mozilla.org/mozilla-central/rev/336801376f35
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.