1449759 - Write an APZ mochitest for bug 1443518

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement, P3)

Description

[Botond Ballo [:botond]]

In bug 1443518 we fixed a Layout bug that caused APZ hit testing to produce incorrect results.

This bug tracks adding an APZ mochitest for that scenario.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1449759 - Add an APZ mochitest for bug 1443518.

Review commit: https://reviewboard.mozilla.org/r/232292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232292/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8963386 [details]
Bug 1449759 - Add an APZ mochitest for bug 1443518.

https://reviewboard.mozilla.org/r/232292/#review237734

That hitTestScrollbar function sure is handy!

::: gfx/layers/apz/test/mochitest/helper_hittest_float_bug1443518.html:11
(Diff revision 1)
> +  <script type="application/javascript" src="apz_test_native_event_utils.js"></script>
> +  <script type="application/javascript" src="/tests/SimpleTest/paint_listener.js"></script>
> +  <meta name="viewport" content="width=device-width"/>
> +  <style>
> +    #div1 {
> +    	position: relative;

there appear to be some tabs here? MozReview is showing red

Comment 3

[Botond Ballo [:botond]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)
> there appear to be some tabs here? MozReview is showing red

One of these days, I'll beat all the editors I use on all my computers into respecting Mozilla's whitespace rules...

Comment 4

[Botond Ballo [:botond]]

Comment on attachment 8963386 [details]
Bug 1449759 - Add an APZ mochitest for bug 1443518.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232292/diff/1-2/

Comment 5

[Botond Ballo [:botond]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)
> That hitTestScrollbar function sure is handy!

Yeah, I love it :) Thanks for figuring out the calculations needed to get it to work, it's really helping us expand our test coverage!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/336801376f35
Add an APZ mochitest for bug 1443518. r=kats

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/336801376f35