Closed
Bug 1449760
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 10224 - Revert "Revert "bluetooth: FakeBluetoothChooser impl.""
Categories
(Testing :: web-platform-tests, defect, P4)
Testing
web-platform-tests
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream error])
Sync web-platform-tests PR 10224 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10224 Details from upstream follow. Ovidio Henriquez <odejesush@chromium.org> wrote: > Revert "Revert "bluetooth: FakeBluetoothChooser impl."" > > This reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a. > > Reason for revert: The failing test was due to not having an updated > copy of > third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js > > Original change description: > > Revert "bluetooth: FakeBluetoothChooser impl." > > > > This reverts commit 188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7. > > > > Reason for revert: https://crbug.com/826787 > > > > Original change's description: > > > bluetooth: FakeBluetoothChooser impl. > > > > > > Implements the interfaces that FakeBluetoothChooser overrides. The > > > mojom::FakeBluetoothChooser overrides are implemented by running > > > |event_handler_| with the appropriate arguments. The BluetoothChooser > > > overrides do nothing at the moment, since the base class is only meant > > > to update the chooser user interface. > > > > > > This change also begins to partially convert a Bluetooth chooser test to test > > > the interface and deletes the temporary tests that were created to test this > > > API. > > > > > > BUG=719827,719826,824704 > > > > > > Change-Id: I56a04e6bdb2de38d9163d7bc350db578deeb9ba3 > > > Reviewed-on: https://chromium-review.googlesource.com/962983 > > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > > Reviewed-by: Conley Owens <cco3@chromium.org> > > > Reviewed-by: Giovanni Ortu?o Urquidi <ortuno@chromium.org> > > > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#546509} > > > > TBR=dcheng@chromium.org,cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org > > > > Change-Id: I0597151ec5878d41ac631b72296203bc99b1f2c8 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 719827, 719826, 824704, 826787 > > Reviewed-on: https://chromium-review.googlesource.com/984299 > > Commit-Queue: Fran?ois Doray <fdoray@chromium.org> > > Reviewed-by: Fran?ois Doray <fdoray@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#546572} > > Bug: 719827, 719826, 824704, 826787 > Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527 > Reviewed-on: https://chromium-review.googlesource.com/985195 > WPT-Export-Revision: dbb1e912d5c4c384b35e2b512f44b253ea3c2647
Reporter | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/23a816b216b1 [wpt PR 10224] - bluetooth: FakeBluetoothChooser impl., a=testonly
Comment 2•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/23a816b216b1
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•