Closed Bug 1449774 Opened 2 years ago Closed 2 years ago

Improve contrast of security text color on dark themes

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox59 --- unaffected
firefox60 --- wontfix
firefox61 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(2 files)

No description provided.
Blocks: 1408121
Attachment #8963416 - Flags: review?(jaws) → review?(jhofmann)
Comment on attachment 8963416 [details]
Bug 1449774 - Improve contrast of security text color on dark themes.

https://reviewboard.mozilla.org/r/232316/#review237880

Hm the red doesn't fare perfectly on https://contrastchecker.com/ (with the black that is on OSX popups right now) but I don't think we can make it any brighter.

I'd say it's definitely an improvement, thanks!
Attachment #8963416 - Flags: review?(jhofmann) → review+
(In reply to Johann Hofmann [:johannh] from comment #3)
> Comment on attachment 8963416 [details]
> Bug 1449774 - Improve contrast of security text color on dark themes.
> 
> https://reviewboard.mozilla.org/r/232316/#review237880
> 
> Hm the red doesn't fare perfectly on https://contrastchecker.com/ (with the
> black that is on OSX popups right now) but I don't think we can make it any
> brighter.
> 
> I'd say it's definitely an improvement, thanks!

Thanks for the review! I left out the non-secure color, since contrast checker says it regressed :)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a69be6eee5a3
Improve contrast of security text color on dark themes. r=johannh
Comment on attachment 8963416 [details]
Bug 1449774 - Improve contrast of security text color on dark themes.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1417880
[User impact if declined]: Bad visibility of security text when using a dark theme that styles the application menu like https://addons.mozilla.org/en-GB/firefox/addon/arc-dark-theme-webextension/ (See bug screenshot)

[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no, low risk change
[Why is the change risky/not risky?]: CSS only
[String changes made/needed]: no
Attachment #8963416 - Flags: approval-mozilla-beta?
Comment on attachment 8963416 [details]
Bug 1449774 - Improve contrast of security text color on dark themes.

I just realized we can't really uplift this to beta, since there's no lwt-popup-brighttext attribute there.
Attachment #8963416 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/a69be6eee5a3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
See Also: → 1575347
You need to log in before you can comment on or make changes to this bug.