1449807 - Don't flush in nsXBLResourceLoader::NotifyBoundElements.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1449807: Don't flush in nsXBLResourceLoader::NotifyBoundElements.

Before bug 1357142, we used to legitimately need to check for redundant
frame tree insertions and such, since we went into frame construction
synchronously.

But after that, all this dance of flushing, querying the primary frame and the
uncomputed maps is just needless. We can just post as many reframes as we want,
they'll be processed properly on the next flush.

This removes one of the queries to the undisplayed map which I'm trying to
remove in bug 1303605. I could have just poked at the style stored in the
element, but this one is easy to just get rid of.

Review commit: https://reviewboard.mozilla.org/r/232350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232350/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=38ac08625c0704ca8e3e3ab77213b17f58dec8d7

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8963440 [details]
Bug 1449807: Don't flush in nsXBLResourceLoader::NotifyBoundElements.

https://reviewboard.mozilla.org/r/232350/#review238236

::: dom/xbl/nsXBLResourceLoader.cpp:238
(Diff revision 1)
>      content->OwnerDoc()->UnblockOnload(/* aFireSync = */ false);
>  
>      bool ready = false;
>      xblService->BindingReady(content, bindingURI, &ready);
>  
> -    if (ready) {
> +    if (!ready) {

It's not actually clear to me whether "ready" can end up false here... seems odd.  Might be worth a followup to make that API saner.

::: dom/xbl/nsXBLResourceLoader.cpp:242
(Diff revision 1)
>  
> -    if (ready) {
> +    if (!ready) {
> +      continue;
> +    }
> +
> -      // We need the document to flush out frame construction and
> +    // We need the document to flush out frame construction and

We're not flushing anything anymore.  Please fix this comment.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/526edefabb8c
Don't flush in nsXBLResourceLoader::NotifyBoundElements. r=bz

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/526edefabb8c