Closed Bug 1449812 Opened 2 years ago Closed 2 years ago

Constify DOMEventTargetHelper::HasListeners and HasListenersFor

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wisniewskit, Assigned: wisniewskit)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Given that these methods don't alter the instance, it seems reasonable to constify them.

(This is split off from the patchset for refactoring XMLHttpRequest in bug 1449613).
Comment on attachment 8963447 [details]
Bug 1449812 - Constify DOMEventTargetHelper::HasListeners and HasListenersFor.

https://reviewboard.mozilla.org/r/232362/#review237812
Attachment #8963447 - Flags: review?(amarchesini) → review+
Looks like it builds fine on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2d2aa43ce2e29a981a6ccca9e9d1ab8074c6598

Requesting check-in.
Keywords: checkin-needed
Assignee: nobody → wisniewskit
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ca8821f2d99f
Constify DOMEventTargetHelper::HasListeners and HasListenersFor. r=baku
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ca8821f2d99f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.