Closed Bug 1449820 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 10229 - [css-typed-om] Add support for grid properties.

Categories

(Core :: DOM: CSS Object Model, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10229 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10229
Details from upstream follow.

Darren Shen <shend@chromium.org> wrote:
>  [css-typed-om] Add support for grid properties.
>  
>  This patch adds support for some grid properties.
>  
>  We add a new <flex> CSS value object, which meant rebaselining all the tests.
>  
>  We're failing some tests because the 'grid', 'grid-template' and
>  'grid-gap' shorthands don't serialize to anything [1], so Typed OM
>  can't create an unsupported style value from it. Not sure if this is
>  a bug...
>  
>  [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp?type=cs&l=406
>  
>  Bug: 820299
>  Change-Id: I8ff871fffed2977ca20a623bd283d7cbdc247870
>  
>  Reviewed-on: https://chromium-review.googlesource.com/984756
>  WPT-Export-Revision: d591b016cd0d4af931c3bb99c447b2a0ff95f4cb
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5c86491e3cc
[wpt PR 10229] - [css-typed-om] Add support for grid properties., a=testonly
https://hg.mozilla.org/mozilla-central/rev/f5c86491e3cc
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.