Closed
Bug 1449829
Opened 5 years ago
Closed 5 years ago
Crash in java.lang.NullPointerException: Attempt to invoke interface method 'int org.mozilla.gecko.process.IChildProcess.getPid()' on a null object reference at org.mozilla.gecko.process.GeckoProcessManager$ChildConnection.getPid(GeckoProcessManager.java)
Categories
(GeckoView :: General, defect, P1)
Tracking
(firefox59 wontfix, firefox60 fixed, firefox61 fixed)
RESOLVED
FIXED
mozilla61
People
(Reporter: jchen, Assigned: rbarker)
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
jchen
:
review+
RyanVM
:
approval-mozilla-beta+
|
Details |
This bug was filed from the Socorro interface and is report bp-6b26f22f-39f9-4047-94bf-0b62b0180328. ============================================================= Top 10 frames of crashing thread: 0 libxul.so mozilla::jni::Accessor::EndAccess<mozilla::java::AndroidGamepadManager::OnGamepadAdded_t> 1 libxul.so mozilla::jni::Method<mozilla::java::GeckoProcessManager::Start_t, int>::Call<mozilla::jni::StringParam, mozilla::jni::Ref<mozilla::jni::TypedObject<jobjectArray>, _jobjectArray*>, int, int, int, int> widget/android/jni/Accessors.h:99 2 libxul.so mozilla::java::GeckoProcessManager::Start widget/android/GeneratedJNIWrappers.cpp:2405 3 libxul.so mozilla::ipc::GeckoChildProcessHost::LaunchAndroidService ipc/glue/GeckoChildProcessHost.cpp:1225 4 libxul.so mozilla::ipc::GeckoChildProcessHost::PerformAsyncLaunchInternal ipc/glue/GeckoChildProcessHost.cpp:812 5 libxul.so mozilla::ipc::GeckoChildProcessHost::PerformAsyncLaunch ipc/glue/GeckoChildProcessHost.cpp:544 6 libxul.so mozilla::ipc::GeckoChildProcessHost::RunPerformAsyncLaunch ipc/glue/GeckoChildProcessHost.cpp:552 7 libxul.so mozilla::detail::RunnableMethodArguments<std::__ndk1::vector<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, std::__ndk1::allocator<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > > > >::applyImpl<mozilla::ipc::GeckoChildProcessHost, bool , StoreCopyPassByConstLRef<std::__ndk1::vector<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, std::__ndk1::allocator<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > > > >, 0> xpcom/threads/nsThreadUtils.h:1164 8 libxul.so mozilla::detail::RunnableMethodImpl<mozilla::ipc::GeckoChildProcessHost*, bool , false, mozilla::RunnableKind::Standard, std::__ndk1::vector<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, std::__ndk1::allocator<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > > > >::Run xpcom/threads/nsThreadUtils.h:1170 9 libxul.so MessageLoop::RunTask ipc/chromium/src/base/message_loop.cc:452 =============================================================
Updated•5 years ago
|
Assignee: nobody → rbarker
Comment hidden (mozreview-request) |
Reporter | ||
Comment 2•5 years ago
|
||
mozreview-review |
Comment on attachment 8963646 [details] Bug 1449829 - Prevent calling getPid() on null IChildProcess https://reviewboard.mozilla.org/r/232530/#review237968
Attachment #8963646 -
Flags: review?(nchen) → review+
Pushed by rbarker@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/26e683b91f09 Prevent calling getPid() on null IChildProcess r=jchen
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/26e683b91f09
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Comment 5•5 years ago
|
||
Please request Beta approval on this when you get a chance.
Flags: needinfo?(rbarker)
Assignee | ||
Comment 6•5 years ago
|
||
Comment on attachment 8963646 [details] Bug 1449829 - Prevent calling getPid() on null IChildProcess Approval Request Comment [Feature/Bug causing the regression]: Unknown [User impact if declined]: Fennec can crash. [Is this code covered by automated tests?]: Not that I know of. [Has the fix been verified in Nightly?]: No [Needs manual test from QE? If yes, steps to reproduce]: Reproduction steps are not known [List of other uplifts needed for the feature/fix]: none. [Is the change risky?]: no [Why is the change risky/not risky?]: It only add a null check. [String changes made/needed]: none
Flags: needinfo?(rbarker)
Attachment #8963646 -
Flags: approval-mozilla-beta?
Comment 7•5 years ago
|
||
Comment on attachment 8963646 [details] Bug 1449829 - Prevent calling getPid() on null IChildProcess Add a null check to fix a crash. Approved for 60.0b9.
Attachment #8963646 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/95e02bd6a13f
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
You need to log in
before you can comment on or make changes to this bug.
Description
•