1449829 - Crash in java.lang.NullPointerException: Attempt to invoke interface method 'int org.mozilla.gecko.process.IChildProcess.getPid()' on a null object reference at org.mozilla.gecko.process.GeckoProcessManager$ChildConnection.getPid(GeckoProcessManager.java)

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1, critical)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is
report bp-6b26f22f-39f9-4047-94bf-0b62b0180328.
=============================================================

Top 10 frames of crashing thread:

0 libxul.so mozilla::jni::Accessor::EndAccess<mozilla::java::AndroidGamepadManager::OnGamepadAdded_t> 
1 libxul.so mozilla::jni::Method<mozilla::java::GeckoProcessManager::Start_t, int>::Call<mozilla::jni::StringParam, mozilla::jni::Ref<mozilla::jni::TypedObject<jobjectArray>, _jobjectArray*>, int, int, int, int> widget/android/jni/Accessors.h:99
2 libxul.so mozilla::java::GeckoProcessManager::Start widget/android/GeneratedJNIWrappers.cpp:2405
3 libxul.so mozilla::ipc::GeckoChildProcessHost::LaunchAndroidService ipc/glue/GeckoChildProcessHost.cpp:1225
4 libxul.so mozilla::ipc::GeckoChildProcessHost::PerformAsyncLaunchInternal ipc/glue/GeckoChildProcessHost.cpp:812
5 libxul.so mozilla::ipc::GeckoChildProcessHost::PerformAsyncLaunch ipc/glue/GeckoChildProcessHost.cpp:544
6 libxul.so mozilla::ipc::GeckoChildProcessHost::RunPerformAsyncLaunch ipc/glue/GeckoChildProcessHost.cpp:552
7 libxul.so mozilla::detail::RunnableMethodArguments<std::__ndk1::vector<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, std::__ndk1::allocator<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > > > >::applyImpl<mozilla::ipc::GeckoChildProcessHost, bool , StoreCopyPassByConstLRef<std::__ndk1::vector<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, std::__ndk1::allocator<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > > > >, 0> xpcom/threads/nsThreadUtils.h:1164
8 libxul.so mozilla::detail::RunnableMethodImpl<mozilla::ipc::GeckoChildProcessHost*, bool , false, mozilla::RunnableKind::Standard, std::__ndk1::vector<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, std::__ndk1::allocator<std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > > > >::Run xpcom/threads/nsThreadUtils.h:1170
9 libxul.so MessageLoop::RunTask ipc/chromium/src/base/message_loop.cc:452

=============================================================

Comment 1

[Randall Barker [:rbarker]]

Attachment: Bug 1449829 - Prevent calling getPid() on null IChildProcess

Review commit: https://reviewboard.mozilla.org/r/232530/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232530/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8963646 [details]
Bug 1449829 - Prevent calling getPid() on null IChildProcess

https://reviewboard.mozilla.org/r/232530/#review237968

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26e683b91f09
Prevent calling getPid() on null IChildProcess r=jchen

Comment 4

[Andrei Ciure[:andrei_ciure]]

https://hg.mozilla.org/mozilla-central/rev/26e683b91f09

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 6

[Randall Barker [:rbarker]]

Comment on attachment 8963646 [details]
Bug 1449829 - Prevent calling getPid() on null IChildProcess

Approval Request Comment
[Feature/Bug causing the regression]: Unknown
[User impact if declined]: Fennec can crash.
[Is this code covered by automated tests?]: Not that I know of.
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: Reproduction steps are not known
[List of other uplifts needed for the feature/fix]: none.
[Is the change risky?]: no
[Why is the change risky/not risky?]: It only add a null check.
[String changes made/needed]: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8963646 [details]
Bug 1449829 - Prevent calling getPid() on null IChildProcess

Add a null check to fix a crash. Approved for 60.0b9.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/95e02bd6a13f