Closed Bug 1449877 Opened 3 years ago Closed 3 years ago
Release geckodriver 0
No description provided.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: -- → P1
I’m running into problems releasing the mozrunner crate: > % cd testing/mozbase/rust/mozrunner > % cargo publish > Updating registry `https://github.com/rust-lang/crates.io-index` > error: all path dependencies must have a version specified when publishing. > dependency `mozprofile` does not specify a version
It is fine to do the attached review in the mean time, but before we can release from (sigh) GitHub, we need to resolve the mozrunner problem since Travis picks up the crate from crates.io.
rillian: In https://bugzilla.mozilla.org/show_bug.cgi?id=1449877#c1 I tried publishing the mozrunner crate but faced a warning from cargo that “path dependencies must have a version specified when publishing”. As far as I can tell, mozprofile _does_ have a version specified, both in its Cargo.toml  and the central lockfile . I’ve tried various incantations of "cargo update -p <crate name>" across mozprofile, mozrunner, mozversion, and geckodriver to no avail. I vaguely remember this worked after we had moved to using cargo workspaces when I published mozrunner 0.6.0, but I’m not sure. Did anything else change recently that could have affected this? Maybe the latest Rust upgrade?  https://searchfox.org/mozilla-central/rev/f5fb323246bf22a3a3b4185882a1c5d8a2c02996/testing/mozbase/rust/mozprofile/Cargo.toml#3  https://searchfox.org/mozilla-central/rev/f5fb323246bf22a3a3b4185882a1c5d8a2c02996/Cargo.lock#1109-1114
Comment on attachment 8964514 [details] Bug 1449877 - Update geckodriver changelog for 0.20.1. https://reviewboard.mozilla.org/r/233242/#review239106 ::: testing/geckodriver/CHANGES.md:6 (Diff revision 1) > Change log > ========== > > All notable changes to this program is documented in this file. > > +0.20.1 (2018-04-03) Make sure to update the date once we are ready to land the patch.
Attachment #8964514 - Flags: review?(hskupin) → review+
Comment on attachment 8964515 [details] Bug 1449877 - Release geckodriver 0.20.1. https://reviewboard.mozilla.org/r/233244/#review239108
Attachment #8964515 - Flags: review?(hskupin) → review+
To quote froydnj on #build: > it *does* seem weird to me that you would have to give path > dependencies explicit versions (the version is right there in the > the pointed-to Cargo.toml!) but maybe it's done deliberately, to > avoid releasing versions that have, say, particular patch-version > dependencies, when all you need is a certain minor version or > minor-version dependencies, when all you need is a major version By hot-patching testing/mozbase/rust/mozrunner/Cargo.toml to point to mozprofile = "0.3.0" and releasing is with "cargo publish --allow-dirty", I was able to get mozrunner 0.6.1 out there. This pain of assembling the build (including having to manually change geckodriver’s Cargo.toml path dependencies to the correct versions on GitHub) will go away once we fix the long tail of dependencies preventing us from releasing off TaskCluster.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/464ed9164e85 Update geckodriver changelog for 0.20.1. r=whimboo https://hg.mozilla.org/integration/autoland/rev/685f18325cea Release geckodriver 0.20.1. r=whimboo
The release has not completely done yet. So reopening.
Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.