Closed
Bug 1449897
Opened 6 years ago
Closed 6 years ago
Identity popup remove button is invisible on themes with dark popups
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 61
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox59 | --- | unaffected |
| firefox60 | --- | fixed |
| firefox61 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(2 files)
|
64.57 KB,
image/png
|
Details | |
|
59 bytes,
text/x-review-board-request
|
johannh
:
review+
RyanVM
:
approval-mozilla-beta+
|
Details |
Screen Shot 2018-03-29 at 12.47.28.png
:johannh reported this on IRC.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8963530 [details] Bug 1449897 - Make identity popup remove button visible on themes with dark popups. https://reviewboard.mozilla.org/r/232476/#review237882 Thanks!
Attachment #8963530 -
Flags: review?(jhofmann) → review+
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/45b87159277d Make identity popup remove button visible on themes with dark popups. r=johannh
|
Assignee | |
Updated•6 years ago
|
status-firefox59:
--- → unaffected
status-firefox60:
--- → fix-optional
status-firefox61:
--- → affected
status-firefox-esr52:
--- → unaffected
|
|
Assignee | |
Updated•6 years ago
|
Summary: Identity popup button is invisible on themes with dark popups → Identity popup remove button is invisible on themes with dark popups
|
|
Assignee | |
Comment 5•6 years ago
|
||
Comment on attachment 8963530 [details] Bug 1449897 - Make identity popup remove button visible on themes with dark popups. Approval Request Comment [Feature/Bug causing the regression]: Bug 1417880 [User impact if declined]: Bad visibility of identity remove button when using a theme that styles the application menu like https://addons.mozilla.org/en-GB/firefox/addon/arc-dark-theme-webextension/ [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: not yet [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no, low risk change [Why is the change risky/not risky?]: CSS only [String changes made/needed]: no
Attachment #8963530 -
Flags: approval-mozilla-beta?
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/45b87159277d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
|
||
Comment 7•6 years ago
|
||
Comment on attachment 8963530 [details] Bug 1449897 - Make identity popup remove button visible on themes with dark popups. Minor theme fix. Approved for 60.0b9.
Attachment #8963530 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 8•6 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-beta/rev/fa0f2489aa7f
|
||
Comment 9•6 years ago
|
||
I have reproduced this bu with Nightly 61.0a1 (2018-03-29) on Windows 10, 64 Bit! This bug's fix is verified with latest Beta! Build ID 20180607135512 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
QA Whiteboard: [bugday-201800606]
You need to log in
before you can comment on or make changes to this bug.
Description
•