Closed Bug 1449925 Opened 2 years ago Closed 2 years ago

The --private command line parameter doesn't work when browser.startup.blankWindow is true

Categories

(Firefox :: Private Browsing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

(Whiteboard: [fxperf:p1])

Attachments

(1 file)

When browser.startup.blankWindow is true, there's already an about:blank window that exists by the time the command line parameter is processed.
Attached patch PatchSplinter Review
When encountering the -private flag, this makes the existing navigator:blank (about:blank) window become private.

I'm removing the warning that was added in bug 800193 because:
- now that add-ons no longer have xpcom access, there's only internal code that can all this.
- bug 1318388 made this safer (by requiring that only about:blank has been loaded before we call this setter).
Attachment #8963579 - Flags: review?(ehsan)
Attachment #8963579 - Flags: review?(ehsan) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/658361dcadf3
make the --private command line parameter work when browser.startup.blankWindow is true, r=Ehsan.
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a04b1417861b
follow-up to fix conflict with bug 1450242, rs=bustage-fix, a=bustage-fix on CLOSED TREE
https://hg.mozilla.org/mozilla-central/rev/658361dcadf3
https://hg.mozilla.org/mozilla-central/rev/a04b1417861b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.