1449946 - mozreview-virtualenv fails to build due to npm cert error

Status: RESOLVED FIXED

(MozReview Graveyard :: Infrastructure, defect)

Description

[Connor Sheehan [:sheehan]]

Running `version-control-tools/create-test-environment` is failing due to a CERT_UNTRUSTED error thrown by npm when applying the mozreview-virtualenv Ansible role to rbweb. This happens here : https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/ansible/roles/mozreview-virtualenv/tasks/main.yml#l30. 

Most of the resources I can find (https://github.com/npm/npm/issues/20191, https://github.com/npm/npm/issues/17828, https://github.com/npm/npm/issues/5057, etc) seem to indicate the cause is an old, expired SSL certificate. Recommended fixes are either set SSL to non-strict (bleh) or update Node/npm. I have updated the role to download a newer version of Node/npm and the build no longer fails. I am working on running the test suite to see if this change breaks anything.

Comment 1

[Phabricator Automation]

Attachment: mozreview: update Node version in mozreview-virtualenv Ansible role (Bug 1449946) r?gps

Comment 2

[Phabricator Automation]

Comment on attachment 8971683 [details]
mozreview: update Node version in mozreview-virtualenv Ansible role (Bug 1449946) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D1059

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/2881897df2c4
mozreview: update Node version in mozreview-virtualenv Ansible role r=gps