1449958 - Properly inherit scale and transform if there's no new transform

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1449958. Properly inherit scale and transform if there's no new transform.

In bug 1447185 we end up drawing at very high resolution because the scale factor getting reset to 1.

Review commit: https://reviewboard.mozilla.org/r/232508/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232508/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8963612 [details]
Bug 1449958. Properly inherit scale and transform if there's no new transform.

https://reviewboard.mozilla.org/r/232508/#review237962

When this is rebased on top of bug 1449640 it will mean that 3d transformed content will also inherit the scale and transform. Is that the desired behaviour? Also, is there any easy way to make a reftest for this?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)
> Comment on attachment 8963612 [details]
> Bug 1449958. Properly inherit scale and transform if there's no new
> transform.
> 
> https://reviewboard.mozilla.org/r/232508/#review237962
> 
> When this is rebased on top of bug 1449640 it will mean that 3d transformed
> content will also inherit the scale and transform. Is that the desired
> behaviour?

I thought about this and decided it was better than just defaulting to 1, but that might be wrong.

> Also, is there any easy way to make a reftest for this?

Maybe. I want to do some more work in this area so I'll think about improving the situation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b246dbb1f82b
Properly inherit scale and transform if there's no new transform. r=kats

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b246dbb1f82b