Closed
Bug 1449986
Opened 6 years ago
Closed 6 years ago
Use NewBuiltinClassInstance instead of NewObjectWithClassProto when proto is nullptr
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file, 1 obsolete file)
|
12.40 KB,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
Calling |NewObjectWithClassProto(JSContext*, HandleObject proto = nullptr, NewObjectKind newKind = GenericObject)| with an absent |proto| argument is exactly identical to calling |NewBuiltinClassInstance(...)|, except that |NewBuiltinClassInstance(...)| was specifically added to cover the use case when |proto| is always |nullptr|. Similar to that case, calling |NewObjectWithClassProto(...)| with an explicit |proto = nullptr| could also be changed to |NewBuiltinClassInstance(...)|.
|
||
Updated•6 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8975584 -
Flags: review?(jorendorff)
|
|
||
Updated•6 years ago
|
Attachment #8975584 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 2•6 years ago
|
||
Rebased to apply cleanly on inbound. Carrying r+.
Attachment #8975584 -
Attachment is obsolete: true
Attachment #8993760 -
Flags: review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=638d715e1948366cfb4b8ffa2bffa271b881efaf
Keywords: checkin-needed
Pushed by nerli@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1f10db43a17e Use NewBuiltinClassInstance when requesting default prototype. r=jorendorff
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1f10db43a17e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•6 years ago
|
status-firefox61:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•