1449986 - Use NewBuiltinClassInstance instead of NewObjectWithClassProto when proto is nullptr

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[André Bargull [:anba]]

Calling |NewObjectWithClassProto(JSContext*, HandleObject proto = nullptr, NewObjectKind newKind = GenericObject)| with an absent |proto| argument is exactly identical to calling |NewBuiltinClassInstance(...)|, except that |NewBuiltinClassInstance(...)| was specifically added to cover the use case when |proto| is always |nullptr|. 

Similar to that case, calling |NewObjectWithClassProto(...)| with an explicit |proto = nullptr| could also be changed to |NewBuiltinClassInstance(...)|.

Comment 1

[André Bargull [:anba]]

Attachment: bug1449986.patch

Comment 2

[André Bargull [:anba]]

Attachment: bug1449986.patch

Rebased to apply cleanly on inbound. Carrying r+.

Comment 3

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=638d715e1948366cfb4b8ffa2bffa271b881efaf

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f10db43a17e
Use NewBuiltinClassInstance when requesting default prototype. r=jorendorff

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1f10db43a17e