Closed
Bug 1450030
Opened 6 years ago
Closed 6 years ago
Convert top nav bar to ReactJS
Categories
(Tree Management :: Treeherder: Frontend, enhancement, P2)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: camd, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
Part of the overall conversion to ReactJS. Estimated difficulty of 6
Reporter | ||
Updated•6 years ago
|
Blocks: treeherder-react
Reporter | ||
Updated•6 years ago
|
Priority: -- → P2
Comment 1•6 years ago
|
||
Reporter | ||
Updated•6 years ago
|
Attachment #8993183 -
Flags: review?(emorley)
Reporter | ||
Updated•6 years ago
|
Attachment #8993183 -
Flags: review?(sclements313)
Comment 2•6 years ago
|
||
Comment on attachment 8993183 [details] [review] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3804 This attachment is for the closed older PR. The new PR didn't get an attachment created since it didn't have a bug number in the title at time of creation, so will need an attachment manually creating (https://github.com/mozilla/github-bugzilla-pr-linker/issues/16).
Attachment #8993183 -
Flags: review?(sclements313)
Attachment #8993183 -
Flags: review?(emorley)
Comment 3•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/28460c5b10281da96c65c599c29e322f8067e2d3 Bug 1450030 - Convert primary nav bar to ReactJS (#3832) * Prevent flicker when switching from Perfherder to Treeherder The page would reload an extra time while the route gets changed. This way, we set it to the default route directly. * Cleanup displayed message when an invalid "repo" param is set * Improve the logic in _checkFieldFilters * Have Perfherder use React login
Reporter | ||
Comment 4•6 years ago
|
||
This also removes the checkboxes next to each Repo in the Repos menu. I think these checkboxes were just confusing and unnecessary. I hope no one misses them.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•6 years ago
|
||
Reporter | ||
Updated•6 years ago
|
Attachment #8993183 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•