Closed Bug 1450032 Opened 6 years ago Closed 6 years ago

Convert bottom (secondary) nav bar to ReactJS

Categories

(Tree Management :: Treeherder: Frontend, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: camd, Assigned: camd)

References

Details

Attachments

(1 file)

Part of the overall conversion to ReactJS.

Estimated difficulty of 6
Priority: -- → P2
Priority: P2 → P1
Attachment #8991455 - Flags: review?(emorley)
Attachment #8991455 - Flags: review?(sclements313)
Comment on attachment 8991455 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3779

A couple selenium tests are still failing.  It sure looks like they SHOULD be passing.  :)  I'll reassign when I've got them passing.  Sorry for the false start.
Attachment #8991455 - Flags: review?(sclements313)
Attachment #8991455 - Flags: review?(emorley)
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
Attachment #8991455 - Flags: review?(emorley)
Attachment #8991455 - Flags: review?(sclements313)
OK, tests are passing now.  Sorry (again) in advance for how large this is...
Attachment #8991455 - Flags: review?(emorley) → review+
Attachment #8991455 - Flags: review?(sclements313) → review+
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/bc4e8a7b1436f04681b5ca0d7f9d78fc302000bb
Bug 1450032 - Convert bottom (secondary) nav bar to ReactJS (#3779)

Also convert term resultState back to resultStatus

I had wanted to migrate to using "resultState" instead, as it
seemed more descriptive of what it is.  But the filter params
are using "resultStatus" and it would not be worth
the effort to migrate.  It doesn't really matter, but I want to be
consistent to remove confusion, so moving these terms back
to "resultStatus"-ish names.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 1479832
Depends on: 1486176
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: