1450038 - Convert HTML Filters to ReactJS

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P2)

Description

[Cameron Dawson [:camd]]

Everything in filters.js.  These will likely turn into helper functions.

Part of the overall conversion to ReactJS.

Estimated difficulty of 2

Comment 1

[Cameron Dawson [:camd]]

Attachment: PR

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8989548 [details] [review]
PR

Left a comment :-)

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3785

Comment 4

[Cameron Dawson [:camd]]

Comment on attachment 8991963 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3785

I'm glad you stopped me on the other PR.  I think this is a better approach for this purpose.

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8991963 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3785

r+ with the `neutrino-custom/lint.js` change :-)

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/135615d308972c10ab19e2352317f37780fa861a
Bug 1450038 - Stop using dangerouslySetInnerHTML (#3785)

Using components based on react-linkify, we can replace all
usages of dangerouslySetInnerHtml.  This also allowed us
to remove a few related helper functions.

enable no-danger eslint rule

Comment 7

[Cameron Dawson [:camd]]

These filters are now only used by Perfherder and the Logviewer.

Comment 8

[Cameron Dawson [:camd]]

We can handle the filters for perfherder and logviewer under their respective bugs.