Closed
Bug 1450042
Opened 6 years ago
Closed 6 years ago
Convert routing and overall App handling to ReactJS
Categories
(Tree Management :: Treeherder: Frontend, enhancement, P2)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: camd, Assigned: camd)
References
Details
Attachments
(1 file)
This may be the last or close-to-last step taken. Though we could do this earlier and use react2angular for some components. I think this will be easier if it's the last step. Part of the overall conversion to ReactJS. Estimated difficulty of 5
Assignee | ||
Updated•6 years ago
|
Blocks: treeherder-react
Assignee | ||
Updated•6 years ago
|
Priority: -- → P2
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/b52813161f7f402f501ff97cf0be9f0a4be8c58d Bug 1450042 - Treeherder converted to full React (#4167)
Comment 3•6 years ago
|
||
I got a New Relic synthetics alert, however it was due to it no longer finding the string `ng-app="treeherder.app"` in the site index response (which is a string I'd arbitrarily picked in bug 1307465 comment 2, since at the time it seemed like something that would be around for a while hehe) rather than anything else. I've updated the monitor conditions to use `<title>Treeherder</title>` instead (the idea of the check being to ensure it doesn't pass if given an HTTP 200 that actually contains a Heroku/gunicorn/... error message). If we even change the page title, we can update the condition when it starts alerting :-)
Assignee: nobody → cdawson
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•6 years ago
|
||
Ahh, thanks for the update on that. :)
You need to log in
before you can comment on or make changes to this bug.
Description
•