Closed Bug 1450101 Opened 6 years ago Closed 6 years ago

Intermittent layout/reftests/xul/treetwisty-svg-context-paint-1.xul == layout/reftests/xul/treetwisty-svg-context-paint-1-ref.xul | image comparison, max difference: 59, number of differing pixels: 35

Categories

(Core :: XUL, defect, P5)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: ntim)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

screenshot (with arrow pointing near the leftmost graphical artifact -- looks like a faint jagged "underline" kind of)
5.61 KB, image/png
Details
Bug 1450101 - Fix Android intermittent on XUL twisty test.
59 bytes, text/x-review-board-request
dholbert
: review+
Details 
Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=170987499&repo=mozilla-central

https://queue.taskcluster.net/v1/task/FN4yh7p5QruLjeFPAh51Ow/runs/0/artifacts/public/logs/live_backing.log

[task 2018-03-29T10:34:00.146Z] 10:34:00     INFO -  REFTEST TEST-START | http://10.0.2.2:8888/tests/layout/reftests/xul/treetwisty-svg-context-paint-1.xul == http://10.0.2.2:8888/tests/layout/reftests/xul/treetwisty-svg-context-paint-1-ref.xul
[task 2018-03-29T10:34:00.146Z] 10:34:00     INFO -  REFTEST INFO | SET PREFERENCE pref(svg.context-properties.content.enabled,true)
[task 2018-03-29T10:34:00.146Z] 10:34:00     INFO -  REFTEST TEST-LOAD | http://10.0.2.2:8888/tests/layout/reftests/xul/treetwisty-svg-context-paint-1.xul | 0 / 1 (0%)
[task 2018-03-29T10:34:10.467Z] 10:34:10     INFO -  REFTEST INFO | drawWindow flags = DRAWWINDOW_DRAW_CARET | DRAWWINDOW_DRAW_VIEW | DRAWWINDOW_USE_WIDGET_LAYERS; window size = 800,1118; test browser size = 800,1000
[task 2018-03-29T10:34:10.467Z] 10:34:10     INFO -  REFTEST INFO | RESTORE PREFERENCE pref(svg.context-properties.content.enabled,false)
[task 2018-03-29T10:34:10.468Z] 10:34:10     INFO -  REFTEST TEST-LOAD | http://10.0.2.2:8888/tests/layout/reftests/xul/treetwisty-svg-context-paint-1-ref.xul | 0 / 1 (0%)
[task 2018-03-29T10:34:10.470Z] 10:34:10     INFO -  REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8888/tests/layout/reftests/xul/treetwisty-svg-context-paint-1.xul == http://10.0.2.2:8888/tests/layout/reftests/xul/treetwisty-svg-context-paint-1-ref.xul | image comparison, max difference: 59, number of differing pixels: 35
The reftest snapshot shows that we've got some graphical artifacts just below the lower "I am a treecell" text.

The log has snapshots from a series of failures (from running the test 10 times). In some of the failures, the artifact is in the testcase, and in others, it's in the reference case.

I'm guessing the artifact is from antialiasing at the bottom of the original position of the text, before the image loads. And then the image loads, and then we re-render with the text shifted over, and we don't quite invalidate the full original bounds of the text, due to a (android-only?) XUL bug with calculating invalidation areas of antialiased text.
Component: SVG → XUL
(Also worth noting: this failure is from a build that *includes* bug 1449118's fix, too. So this is unrelated to the failures in bug 1449118.)

This test-failure is probably indicative of a real (minor) XUL-text bug (possibly Android-specific).  But XUL's relevance is waning, and it's pretty irrelevant on Android, so I don't think we should care too much about investigating the bug.

I see two easy solutions here:
 (1) Replace the text with characters that don't have any descenders (or anything close to a descender), to avoid the possibility of antialiasing fringes being excluded from the line's invalidation area. Specifically: maybe replace both lines of text with "----" or "====="


...or:
 (2) just add a "fuzzy-if(Android,59,35)" annotation to reftest.list
Comment on attachment 8963816 [details]
Bug 1450101 - Fix Android intermittent on XUL twisty test.

https://reviewboard.mozilla.org/r/232660/#review238138
Attachment #8963816 - Flags: review?(dholbert) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/56d9dd8f9789
Fix Android intermittent on XUL twisty test. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/56d9dd8f9789
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee: nobody → ntim.bugs
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: