Closed Bug 1450127 Opened 2 years ago Closed Last year

[wpt-sync] Sync PR 10247 - RTCPeerConnection.getStats(MediaStreamTrack? selector = null) added.

Categories

(Testing :: web-platform-tests, defect, P4)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 10247 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10247
Details from upstream follow.

Henrik Boström <hbos@chromium.org> wrote:
>  RTCPeerConnection.getStats(MediaStreamTrack? selector = null) added.
>  
>  Implements the RTCPeerConnection.getStats(MediaStreamTrack) version[1]
>  of the stats selection algorithm behind flag. This is the equivalent of
>  doing RTCRtpSender.getStats() or RTCRtpReceiver.getStats() for the
>  track's sender or receiver. This is tested in external/wpt/.
>  
>  Due to limitations of the generated V8 bindings it is not possible to
>  express all versions of RTCPeerConnection.getStats() at the same time
>  in IDL. Thus this CL introduces a version of getStats() taking
>  "optional any callbacksOrSelector" as argument, with custom binding
>  logic performed in RTCPeerConnection.cpp. A fast/peerconnection/
>  LayoutTest is added to test all combinations.
>  
>  [1] https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-getstats
>  
>  Bug: 680172
>  Change-Id: I8c64fc64c708d266c926dfa3eb3587c4cbb31210
>  Reviewed-on: https://chromium-review.googlesource.com/978128
>  WPT-Export-Revision: bf73926ec60650dfc3b4e93e5aa40c3c18089516
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d296a3a1539
[wpt PR 10247] - RTCPeerConnection.getStats(MediaStreamTrack? selector = null) added., a=testonly
https://hg.mozilla.org/mozilla-central/rev/3d296a3a1539
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.