Closed Bug 1450134 Opened 2 years ago Closed 2 years ago

Remove StackingContextHelper point/rect conversion functions

Categories

(Core :: Graphics: WebRender, enhancement)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

Attachments

(2 files)

Bug 1450134. Remove ToRelativeLayoutPoint().
59 bytes, text/x-review-board-request
kats
: review+
Details
Bug 1450134. Replace ToRelativeLayoutRect() with ToRoundedLayoutRect().
59 bytes, text/x-review-board-request
kats
: review+
Details 
No description provided.
Blocks: 1450126
Assignee: nobody → jmuizelaar
Comment on attachment 8963788 [details]
Bug 1450134. Remove ToRelativeLayoutPoint().

https://reviewboard.mozilla.org/r/232654/#review238122
Attachment #8963788 - Flags: review?(bugmail) → review+
Comment on attachment 8963789 [details]
Bug 1450134. Replace ToRelativeLayoutRect() with ToRoundedLayoutRect().

https://reviewboard.mozilla.org/r/232656/#review238124

::: gfx/webrender_bindings/WebRenderTypes.h:317
(Diff revision 1)
>  static inline wr::LayoutVector2D ToLayoutVector2D(const mozilla::LayoutDeviceIntPoint& point)
>  {
>    return ToLayoutVector2D(LayoutDevicePoint(point));
>  }
>  
> +static inline wr::LayoutRect ToRoundedLayoutRect(const mozilla::LayoutDeviceRect& rect) {

s/rect/aRect/ or this won't compile
Attachment #8963789 - Flags: review?(bugmail) → review+
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0090c5c5c069
Remove ToRelativeLayoutPoint(). r=kats
https://hg.mozilla.org/integration/autoland/rev/9ebf785a75d1
Replace ToRelativeLayoutRect() with ToRoundedLayoutRect(). r=kats
https://hg.mozilla.org/mozilla-central/rev/0090c5c5c069
https://hg.mozilla.org/mozilla-central/rev/9ebf785a75d1
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.