1450134 - Remove StackingContextHelper point/rect conversion functions

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1450134. Remove ToRelativeLayoutPoint().

It's completely unused.

Review commit: https://reviewboard.mozilla.org/r/232654/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232654/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1450134. Replace ToRelativeLayoutRect() with ToRoundedLayoutRect().

This function doesn't use any StackingContextHelper state anymore.
We should make what it does clearer and move it to a better place.

Review commit: https://reviewboard.mozilla.org/r/232656/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232656/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8963788 [details]
Bug 1450134. Remove ToRelativeLayoutPoint().

https://reviewboard.mozilla.org/r/232654/#review238122

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8963789 [details]
Bug 1450134. Replace ToRelativeLayoutRect() with ToRoundedLayoutRect().

https://reviewboard.mozilla.org/r/232656/#review238124

::: gfx/webrender_bindings/WebRenderTypes.h:317
(Diff revision 1)
>  static inline wr::LayoutVector2D ToLayoutVector2D(const mozilla::LayoutDeviceIntPoint& point)
>  {
>    return ToLayoutVector2D(LayoutDevicePoint(point));
>  }
>  
> +static inline wr::LayoutRect ToRoundedLayoutRect(const mozilla::LayoutDeviceRect& rect) {

s/rect/aRect/ or this won't compile

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8963789 [details]
Bug 1450134. Replace ToRelativeLayoutRect() with ToRoundedLayoutRect().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232656/diff/1-2/

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8963789 [details]
Bug 1450134. Replace ToRelativeLayoutRect() with ToRoundedLayoutRect().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232656/diff/2-3/

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8963789 [details]
Bug 1450134. Replace ToRelativeLayoutRect() with ToRoundedLayoutRect().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232656/diff/3-4/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0090c5c5c069
Remove ToRelativeLayoutPoint(). r=kats
https://hg.mozilla.org/integration/autoland/rev/9ebf785a75d1
Replace ToRelativeLayoutRect() with ToRoundedLayoutRect(). r=kats

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0090c5c5c069
https://hg.mozilla.org/mozilla-central/rev/9ebf785a75d1