1450142 - TextInputController needs a method for suppressing the soft input keyboard

Status: RESOLVED FIXED

(GeckoView :: IME, enhancement)

Description

[Randall Barker [:rbarker]]

Currently, when the GeckoInputConnection is created by TextInputController, it will always request the soft input keyboard be shown prior to text input. For VR applications, the soft input keyboard will cover the view. EditText has a function called setShowSoftInputOnFocus which suppresses the keyboard on focus. TextInputController needs a similar function.

Comment 1

[Randall Barker [:rbarker]]

Attachment: Bug 1450142 - Add setShowSoftInputOnFocus() to TextInputController

Review commit: https://reviewboard.mozilla.org/r/232680/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232680/

Comment 2

[Randall Barker [:rbarker]]

In the hour since I wrote this, TextInputController has been renamed SessionTextInput but the idea still stands.

Comment 3

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 8963815 [details]
Bug 1450142 - Add setShowSoftInputOnFocus() to TextInputController

https://reviewboard.mozilla.org/r/232680/#review238196

Looks good to me.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8963815 [details]
Bug 1450142 - Add setShowSoftInputOnFocus() to TextInputController

https://reviewboard.mozilla.org/r/232680/#review238296

::: mobile/android/geckoview/src/main/java/org/mozilla/geckoview/SessionTextInput.java:298
(Diff revision 1)
> +    /**
> +     * Prevent soft input when gaining focus
> +     *
> +     * @param showSoftInputOnFocus If true, soft input will be shown on focus
> +     */
> +    public void setShowSoftInputOnFocus(boolean showSoftInputOnFocus) {

This should be `synchronized`

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8963815 [details]
Bug 1450142 - Add setShowSoftInputOnFocus() to TextInputController

https://reviewboard.mozilla.org/r/232680/#review238298

::: mobile/android/geckoview/src/main/java/org/mozilla/geckoview/SessionTextInput.java:294
(Diff revision 1)
>          ThreadUtils.assertOnUiThread();
>          return mInputConnection != null && mInputConnection.isInputActive();
>      }
> +
> +    /**
> +     * Prevent soft input when gaining focus

Also, I think this should be "Set whether soft input is shown when an input field gains focus."

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3634b781cadf
Add setShowSoftInputOnFocus() to SessionTextInput r=jchen,droeh

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3634b781cadf

Comment 8

[Chris Peterson [:cpeterson]]

Moving some keyboard bugs to the new GeckoView::IME component.