lastModifiedTime sometimes isn't

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P1
normal
RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: kmag, Assigned: kmag)

Tracking

unspecified
mozilla61
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

a year ago
No description provided.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

a year ago
mozreview-review
Comment on attachment 8963829 [details]
Bug 1450154: Clone file objects before checking lastModifiedTime.

https://reviewboard.mozilla.org/r/232702/#review238274
Attachment #8963829 - Flags: review?(aswan) → review+

Comment 6

a year ago
mozreview-review
Comment on attachment 8963835 [details]
Bug 1450154: Part 2 - Make test_install.js a bit less insane.

https://reviewboard.mozilla.org/r/232704/#review238278

::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:122
(Diff revision 2)
> +    } else if (value && typeof value === "object") {
> +      deepEqual(install[key], value, `Expected value of install.${key}`);
> +    } else {
> +      equal(install[key], value, `Expected value of install.${key}`);
> +    }

it looks like deepEqual() can compare primitive types so these two could be collapsed (same in checkAddon() in head.js if you care)
Attachment #8963835 - Flags: review?(aswan) → review+
Priority: -- → P1

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4538701b117a
https://hg.mozilla.org/mozilla-central/rev/e80c38ee4fc3
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61

Comment 9

a year ago
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(kmaglione+bmo)
Assignee

Updated

8 months ago
Flags: needinfo?(kmaglione+bmo) → qe-verify-
You need to log in before you can comment on or make changes to this bug.