Closed
Bug 1450182
Opened 6 years ago
Closed 6 years ago
Remove the EventListenerWasAdded/Removed hooks from DOMEventTargetHelper
Categories
(Core :: DOM: Events, enhancement)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
15.96 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
We already have an EventListenerAdded/Removed hook. We should just use that. It does involve a bit more codegen work, but simplifies the DOMEventTargetHelper setup and removes some vtable bits. And generates smaller code in the codegen, too.
|
Assignee | |
Comment 1•6 years ago
|
||
MozReview-Commit-ID: GWnAvK61hVT
Attachment #8963867 -
Flags: review?(bugs)
|
||
Updated•6 years ago
|
Attachment #8963867 -
Flags: review?(bugs) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1c00083d6616 Remove the EventListenerWasAdded/Removed hooks from DOMEventTargetHelper. r=smaug
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1c00083d6616
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•