1450234 - The highlight is exceeding the borders of the iframe when scrolling or dragging the points

Status: RESOLVED WONTFIX

(DevTools :: Inspector, defect)

Description

[Hani Yacoub, Desktop QA]

Attachment: iframe.png

[Affected versions]: 
Nightly 61.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Windows 7 x 32, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. Go to about:config and set "layout.css.shape-outside.enabled" to true.
2. Go to "https://drive.google.com/file/d/1zAOwoVHBDk8RmX97N7lvvdbd5KPWRk6u/view?usp=sharing" downloaded it in .html formate and open it with Firefox, Make sure the element is inside the iframe.
3. Right click on the image and then click on "Inspect Element".
4. Click on the button displayed next to clip-path to toggle the shape tool on, and make sure the page is iframed.
5. Scroll up/down, or drag the points to change the shape.

[Expected result]:
- The highlight should not exceed the borders of the iframe when scrolling.
- Once the point is dragged the shape should be changed but it should not exceed the borders of the iframe.

[Actual result]:
- The highlight is exceeding the borders of the iframe when scrolling or dragging the points.

Comment 1

[Patrick Brosset <:pbro>]

This is actually an expected behavior that makes it easier for users to make modifications to their shapes, even when they are in (possibly very small) iframes.
All of the different DevTools overlays share this principle, they always appear on the very top of the page, always above everything else, and not hidden when things are behind overflow areas.
So I'll close this as WONTFIX.

Comment 2

[Rares Doghi, Desktop QA]

Hi Patrick, in version 61.0a1 (2018-04-19) , The Highlighter points are locked inside an iFrame and the user is unable to move them outside since this Issue was fixed https://bugzilla.mozilla.org/show_bug.cgi?id=1450650 , is this the correct behavior now  ? Small iFrames might indeed be an issue for everyone in this case.

Comment 3

[Patrick Brosset <:pbro>]

Thanks for raising this issue. I believe we should only ever constrain the user to the parent window boundary. So, it should still be possible to drag points past the boundaries of an iframe.

Comment 4

[Rares Doghi, Desktop QA]

(In reply to Patrick Brosset <:pbro> from comment #3)
> Thanks for raising this issue. I believe we should only ever constrain the
> user to the parent window boundary. So, it should still be possible to drag
> points past the boundaries of an iframe.

Thanks Patrick, i added this defect for it https://bugzilla.mozilla.org/show_bug.cgi?id=1455588 , the user should be able to drag the points outside of the iFrame but the points should still be constrained to the parent window.