1450240 - Remove the overlays in preferences with inlining and preprocessing

Status: RESOLVED FIXED

(Thunderbird :: Preferences, enhancement)

Description

[Richard Marti (:Paenglab)]

The different panes use an overlay to load into the preferences window/tab.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: preferencesOverlay.patch

I see the same errors as without the patch like:
 document.getAnonymousElementByAttribute(...) is null handlers.xml:29
or when opening the password dialog:
[Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIIOService.newURI]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource://gre/modules/NetUtil.jsm :: NetUtil_newURI :: line 204"  data: no]
[Exception... "Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService.newURI]"  nsresult: "0x804b000a (NS_ERROR_MALFORMED_URI)"  location: "JS frame :: resource://gre/modules/NetUtil.jsm :: NetUtil_newURI :: line 204"  data: no]
favicon not found for uri

So this patch should be save.

I can file a bug for the password dialog errors if you want.

Comment 2

[Richard Marti (:Paenglab)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0c11b2fb5264960e0080516b5ee67827b43ced5f

And filed bug 1450246 for the password dialog.

Comment 3

[Jorg K (CEST = GMT+2)]

Why are the new files called xxx.inc.xul and not just xxx.inc? I should have asked that earlier since there are already heaps of .inc.xul files now. But better late than never ;-)

Comment 4

[Richard Marti (:Paenglab)]

I've done this because FX does this too. And this files are almost complete XUL files which miss only the headers and the last line. Other files I named only xxx.inc are only snippets of XUL files. But if you want to rename them, I can do this. I have no big preference how they should be named.

Comment 5

[Jorg K (CEST = GMT+2)]

Just asking. I'll try it now.

Comment 6

[Jorg K (CEST = GMT+2)]

I clicked myself through all the preferences. Attachments is missing the "Incoming"/"Outgoing" tabs.

Comment 7

[Richard Marti (:Paenglab)]

Here they are present. Have you errors in the console?

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 8963924 [details] [diff] [review]
preferencesOverlay.patch

The profile had cloud files disabled via mail.cloud_files.enabled. All good.

Comment 9

[Richard Marti (:Paenglab)]

Thanks.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3e4da1fe6a9b
Remove the overlays in preferences with inlining and pre-processing. r=jorgk